You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/05/05 22:44:26 UTC

[Impala-ASF-CR] [tools] update gitignore files

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18499


Change subject: [tools] update gitignore files
......................................................................

[tools] update gitignore files

Updates gitignore for files generated during bootstrap_development.
Particularly includes ignore rules for past versions of shell
dependencies and updates ignores for current versions.

Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
---
M .gitignore
M fe/src/test/resources/.gitignore
M infra/python/.gitignore
A java/shaded-deps/hive-exec/.gitignore
M shell/.gitignore
M testdata/cluster/.gitignore
6 files changed, 24 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/18499/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-11201: update gitignore files

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18499 )

Change subject: IMPALA-11201: update gitignore files
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 09 May 2022 01:25:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11201: update gitignore files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18499 )

Change subject: IMPALA-11201: update gitignore files
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10539/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 06 May 2022 18:46:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] update gitignore files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18499 )

Change subject: [tools] update gitignore files
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10533/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 May 2022 23:13:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] update gitignore files

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18499 )

Change subject: [tools] update gitignore files
......................................................................


Patch Set 2:

(2 comments)

Thanks for cleaning up these!

http://gerrit.cloudera.org:8080/#/c/18499/2/.gitignore
File .gitignore:

http://gerrit.cloudera.org:8080/#/c/18499/2/.gitignore@4
PS2, Line 4: thirdparty
It'd be nice if this patch can remove this and fix IMPALA-11201 as well.


http://gerrit.cloudera.org:8080/#/c/18499/2/shell/.gitignore
File shell/.gitignore:

http://gerrit.cloudera.org:8080/#/c/18499/2/shell/.gitignore@3
PS2, Line 3: ext-py/bitarray-2.3.0/dist/
missing "ext-py/bitarray-2.3.0/dist/build"?



-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 06 May 2022 08:41:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11201: update gitignore files

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18499 )

Change subject: IMPALA-11201: update gitignore files
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18499/2/.gitignore
File .gitignore:

http://gerrit.cloudera.org:8080/#/c/18499/2/.gitignore@4
PS2, Line 4: thirdparty
> It'd be nice if this patch can remove this and fix IMPALA-11201 as well.
Done and updated the patch to relate to IMPALA-11201.


http://gerrit.cloudera.org:8080/#/c/18499/2/shell/.gitignore
File shell/.gitignore:

http://gerrit.cloudera.org:8080/#/c/18499/2/shell/.gitignore@3
PS2, Line 3: ext-py/bitarray-2.3.0/dist/
> missing "ext-py/bitarray-2.3.0/dist/build"?
Turned out line 1 was matching all build directories. I've made it more precise and added `build/` for bitarray.



-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 06 May 2022 18:32:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11201: update gitignore files

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18499

to look at the new patch set (#3).

Change subject: IMPALA-11201: update gitignore files
......................................................................

IMPALA-11201: update gitignore files

Updates gitignore for files generated during bootstrap_development.
Fixes deleting tracked files in be/src/thirdparty. Includes ignore rules
for past versions of shell dependencies and updates ignores for current
versions.

Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
---
M .gitignore
M fe/src/test/resources/.gitignore
M infra/python/.gitignore
A java/shaded-deps/hive-exec/.gitignore
M shell/.gitignore
M testdata/cluster/.gitignore
6 files changed, 27 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/18499/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11201: update gitignore files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18499 )

Change subject: IMPALA-11201: update gitignore files
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8086/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 09 May 2022 22:15:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] update gitignore files

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18499 )

Change subject: [tools] update gitignore files
......................................................................

[tools] update gitignore files

Updates gitignore for files generated during bootstrap_development.
Particularly includes ignore rules for past versions of shell
dependencies and updates ignores for current versions.

Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
---
M .gitignore
M fe/src/test/resources/.gitignore
M infra/python/.gitignore
A java/shaded-deps/hive-exec/.gitignore
M shell/.gitignore
M testdata/cluster/.gitignore
6 files changed, 24 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/18499/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11201: update gitignore files

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18499 )

Change subject: IMPALA-11201: update gitignore files
......................................................................

IMPALA-11201: update gitignore files

Updates gitignore for files generated during bootstrap_development.
Fixes deleting tracked files in be/src/thirdparty. Includes ignore rules
for past versions of shell dependencies and updates ignores for current
versions.

Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Reviewed-on: http://gerrit.cloudera.org:8080/18499
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M .gitignore
M fe/src/test/resources/.gitignore
M infra/python/.gitignore
A java/shaded-deps/hive-exec/.gitignore
M shell/.gitignore
M testdata/cluster/.gitignore
6 files changed, 27 insertions(+), 12 deletions(-)

Approvals:
  Quanlong Huang: Looks good to me, but someone else must approve
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] [tools] update gitignore files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18499 )

Change subject: [tools] update gitignore files
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10532/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 May 2022 23:04:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11201: update gitignore files

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18499 )

Change subject: IMPALA-11201: update gitignore files
......................................................................


Patch Set 3: Code-Review+2

Looks good to me


-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 10 May 2022 00:50:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11201: update gitignore files

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18499 )

Change subject: IMPALA-11201: update gitignore files
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084
Gerrit-Change-Number: 18499
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 10 May 2022 02:49:29 +0000
Gerrit-HasComments: No