You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2017/09/05 17:38:40 UTC
[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)
Philip Zeyliger has posted comments on this change.
Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7829/3/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java
File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java:
PS3, Line 319: boolean ret = (rewritten instanceof BoolLiteral && ((BoolLiteral) rewritten).getValue());
> I assume you meant to delete this line
Done
http://gerrit.cloudera.org:8080/#/c/7829/3/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java:
Line 436: RewritesOk("isnottrue(null)", rule, "TRUE"); RewritesOk("isfalse(true)", rule, "FALSE");
> nit next line
Done
PS3, Line 451: rules
> as we discussed, it'd be helpful to rename this
I just added a small comment here, to avoid a somewhat annoying rename. Happy to be overwritten, it would just introduce a lot of diff noise in this large test function.
--
To view, visit http://gerrit.cloudera.org:8080/7829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id91ca968a0c0be44e1ec54ad8602f91a5cb2e0e5
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-HasComments: Yes