You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by Andrzej <a....@gmail.com> on 2023/05/27 06:56:58 UTC
Versions maven plugin
Hi all,
I've been looking at Versions Maven Plugin and I can say that there are a
few places that could use some refactoring.
For example, VersionDetails and AbstractArtifactVersions serve several
purposes: they seem to be both a collection of cached artifact versions,
but at the same time store the information on the current version (unless
they don't – like PropertyVersions which is a child of
AbstractArtifactVersions). On top of that, they offer plenty of different
utility methods for retrieving versions which may or not duplicate
themselves.
So, let's suppose I wanted to refactor that a little bit: is it ok to use
Aether (like e.g. org.eclipse.aether.artifact.Artifact or
org.eclipse.aether.version.VersionRange) API there? Or should I be looking
somewhere else?
Best regards,
Andrzej
Re: Versions maven plugin
Posted by Tamás Cservenák <ta...@cservenak.net>.
Howdy,
sorry I missed this thread.
But spotted when you closed this issue, so answered there:
https://github.com/mojohaus/versions/issues/961#issuecomment-1946797974
On Sat, May 27, 2023 at 8:57 AM Andrzej <a....@gmail.com> wrote:
> Hi all,
>
> I've been looking at Versions Maven Plugin and I can say that there are a
> few places that could use some refactoring.
>
> For example, VersionDetails and AbstractArtifactVersions serve several
> purposes: they seem to be both a collection of cached artifact versions,
> but at the same time store the information on the current version (unless
> they don't – like PropertyVersions which is a child of
> AbstractArtifactVersions). On top of that, they offer plenty of different
> utility methods for retrieving versions which may or not duplicate
> themselves.
>
> So, let's suppose I wanted to refactor that a little bit: is it ok to use
> Aether (like e.g. org.eclipse.aether.artifact.Artifact or
> org.eclipse.aether.version.VersionRange) API there? Or should I be looking
> somewhere else?
>
> Best regards,
> Andrzej
>
Re: Versions maven plugin
Posted by Gary Gregory <ga...@gmail.com>.
You'll need to know what the binary compatibility policy is for this plugin.
Gary
On Sat, May 27, 2023, 02:57 Andrzej <a....@gmail.com> wrote:
> Hi all,
>
> I've been looking at Versions Maven Plugin and I can say that there are a
> few places that could use some refactoring.
>
> For example, VersionDetails and AbstractArtifactVersions serve several
> purposes: they seem to be both a collection of cached artifact versions,
> but at the same time store the information on the current version (unless
> they don't – like PropertyVersions which is a child of
> AbstractArtifactVersions). On top of that, they offer plenty of different
> utility methods for retrieving versions which may or not duplicate
> themselves.
>
> So, let's suppose I wanted to refactor that a little bit: is it ok to use
> Aether (like e.g. org.eclipse.aether.artifact.Artifact or
> org.eclipse.aether.version.VersionRange) API there? Or should I be looking
> somewhere else?
>
> Best regards,
> Andrzej
>