You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/06/29 19:07:38 UTC
[GitHub] [superset] justinpark opened a new pull request, #24554: chore(sqllab): Log current local storage usage
justinpark opened a new pull request, #24554:
URL: https://github.com/apache/superset/pull/24554
### SUMMARY
This commit adds a logging event for the current local storage size for monitoring purpose.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
<img width="494" alt="Screenshot 2023-06-29 at 11 57 50 AM" src="https://github.com/apache/superset/assets/1392866/b5c474d9-e7ee-401a-b599-a44179179746">
Before: N/A
### TESTING INSTRUCTIONS
Go to SQLLab and check the network tab for the logging event
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24554: chore(sqllab): Log current local storage usage
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24554:
URL: https://github.com/apache/superset/pull/24554#issuecomment-1613736319
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24554](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1d9bb2e) into [master](https://app.codecov.io/gh/apache/superset/commit/e20b69587f351056f5f997c19f438b12302dcf0b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e20b695) will **increase** coverage by `0.02%`.
> The diff coverage is `81.81%`.
> :exclamation: Current head 1d9bb2e differs from pull request most recent head 126583f. Consider uploading reports for the commit 126583f to get more accurate results
```diff
@@ Coverage Diff @@
## master #24554 +/- ##
==========================================
+ Coverage 69.06% 69.08% +0.02%
==========================================
Files 1901 1906 +5
Lines 74019 74126 +107
Branches 8116 8156 +40
==========================================
+ Hits 51121 51211 +90
- Misses 20787 20795 +8
- Partials 2111 2120 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.78% <74.07%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ackages/superset-ui-chart-controls/src/fixtures.ts](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2ZpeHR1cmVzLnRz) | `100.00% <ø> (ø)` | |
| [...d/packages/superset-ui-chart-controls/src/types.ts](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [.../superset-ui-core/src/models/ExtensibleFunction.ts](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvbW9kZWxzL0V4dGVuc2libGVGdW5jdGlvbi50cw==) | `100.00% <ø> (ø)` | |
| [...ges/superset-ui-core/src/query/types/Datasource.ts](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvRGF0YXNvdXJjZS50cw==) | `100.00% <ø> (ø)` | |
| [...ackages/superset-ui-core/src/query/types/Metric.ts](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvTWV0cmljLnRz) | `100.00% <ø> (ø)` | |
| [...rts/src/BigNumber/BigNumberTotal/transformProps.ts](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclRvdGFsL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| [.../plugins/plugin-chart-echarts/src/BoxPlot/index.ts](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQm94UGxvdC9pbmRleC50cw==) | `50.00% <ø> (ø)` | |
| [...d/plugins/plugin-chart-echarts/src/Funnel/index.ts](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvRnVubmVsL2luZGV4LnRz) | `50.00% <ø> (ø)` | |
| [...nd/plugins/plugin-chart-echarts/src/Gauge/index.ts](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR2F1Z2UvaW5kZXgudHM=) | `50.00% <ø> (ø)` | |
| [...nd/plugins/plugin-chart-echarts/src/Graph/index.ts](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR3JhcGgvaW5kZXgudHM=) | `50.00% <ø> (ø)` | |
| ... and [75 more](https://app.codecov.io/gh/apache/superset/pull/24554?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on a diff in pull request #24554: chore(sqllab): Log current local storage usage
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #24554:
URL: https://github.com/apache/superset/pull/24554#discussion_r1247175918
##########
superset-frontend/src/SqlLab/components/App/index.jsx:
##########
@@ -121,14 +124,27 @@ class App extends React.PureComponent {
}
componentDidUpdate() {
+ const { localStorageUsageInKilobytes, actions, queries } = this.props;
+ const queryCount = queries?.lenghth || 0;
if (
- this.props.localStorageUsageInKilobytes >=
+ localStorageUsageInKilobytes >=
LOCALSTORAGE_WARNING_THRESHOLD * LOCALSTORAGE_MAX_USAGE_KB
) {
this.showLocalStorageUsageWarning(
- this.props.localStorageUsageInKilobytes,
- this.props.queries?.lenghth || 0,
+ localStorageUsageInKilobytes,
+ queryCount,
+ );
+ }
+ if (localStorageUsageInKilobytes > 0 && !this.hasLoggedLocalStorageUsage) {
Review Comment:
That's right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #24554: chore(sqllab): Log current local storage usage
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #24554:
URL: https://github.com/apache/superset/pull/24554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #24554: chore(sqllab): Log current local storage usage
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #24554:
URL: https://github.com/apache/superset/pull/24554#discussion_r1247120705
##########
superset-frontend/src/SqlLab/components/App/index.jsx:
##########
@@ -121,14 +124,27 @@ class App extends React.PureComponent {
}
componentDidUpdate() {
+ const { localStorageUsageInKilobytes, actions, queries } = this.props;
+ const queryCount = queries?.lenghth || 0;
if (
- this.props.localStorageUsageInKilobytes >=
+ localStorageUsageInKilobytes >=
LOCALSTORAGE_WARNING_THRESHOLD * LOCALSTORAGE_MAX_USAGE_KB
) {
this.showLocalStorageUsageWarning(
- this.props.localStorageUsageInKilobytes,
- this.props.queries?.lenghth || 0,
+ localStorageUsageInKilobytes,
+ queryCount,
+ );
+ }
+ if (localStorageUsageInKilobytes > 0 && !this.hasLoggedLocalStorageUsage) {
Review Comment:
Is only the initial local storage usage monitored?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org