You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by willholley <gi...@git.apache.org> on 2016/08/01 17:52:09 UTC

[GitHub] couchdb-chttpd pull request #135: Handle empty "Access-Control-Request-Heade...

GitHub user willholley opened a pull request:

    https://github.com/apache/couchdb-chttpd/pull/135

    Handle empty "Access-Control-Request-Headers" header

    When "Access-Control-Request-Headers" is empty, return an empty
    "Access-Control-Allow-Headers" in the response. This is the same
    behaviour as when the "Access-Control-Request-Headers" header is
    omitted from the request entirely.
    
    Fixes COUCHDB-3090

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/willholley/couchdb-chttpd 3090-handle-empty-access-control-request-headers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-chttpd/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #135
    
----
commit 232bfe6d37b079096d1db4f786ff9c3c403c1fba
Author: Will Holley <wi...@gmail.com>
Date:   2016-08-01T16:57:44Z

    Handle empty "Access-Control-Request-Headers" header
    
    When "Access-Control-Request-Headers" is empty, return an empty
    "Access-Control-Allow-Headers" in the response. This is the same
    behaviour as when the "Access-Control-Request-Headers" header is
    omitted from the request entirely.
    
    Fixes COUCHDB-3090

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...

Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the issue:

    https://github.com/apache/couchdb-chttpd/pull/135
  
    cc @rnewson @davisp @iilyak 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...

Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:

    https://github.com/apache/couchdb-chttpd/pull/135
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...

Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the issue:

    https://github.com/apache/couchdb-chttpd/pull/135
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...

Posted by willholley <gi...@git.apache.org>.
Github user willholley commented on the issue:

    https://github.com/apache/couchdb-chttpd/pull/135
  
    I've seen a few users run into this problem. Any chance of getting it merged now we past 2.0?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd pull request #135: Handle empty "Access-Control-Request-Heade...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-chttpd/pull/135


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...

Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the issue:

    https://github.com/apache/couchdb-chttpd/pull/135
  
    @barbalex Yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...

Posted by barbalex <gi...@git.apache.org>.
Github user barbalex commented on the issue:

    https://github.com/apache/couchdb-chttpd/pull/135
  
    Thanks a lot. Will wee find this in CouchDB v1.7?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---