You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/28 15:59:12 UTC
[GitHub] [airflow] bbovenzi opened a new pull request #16696: Improve graph view refresh
bbovenzi opened a new pull request #16696:
URL: https://github.com/apache/airflow/pull/16696
- only refresh if state has actually changed
- stop refresh if all states are final
- swap out `.attr()` to `.prop()` for handling `checked` see https://stackoverflow.com/questions/5874652/prop-vs-attr
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16696: Improve graph view refresh
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16696:
URL: https://github.com/apache/airflow/pull/16696#discussion_r660520186
##########
File path: airflow/www/static/js/graph.js
##########
@@ -364,14 +364,34 @@ function setFocusMap(state) {
const stateIsSet = () => !!Object.keys(stateFocusMap).find((key) => stateFocusMap[key]);
+let prevTis;
+
function handleRefresh() {
$('#loading-dots').css('display', 'inline-block');
$.get(getTaskInstanceURL)
.done(
(tis) => {
+ // only refresh if the data has changed
+ if (prevTis !== tis) {
// eslint-disable-next-line no-global-assign
- taskInstances = JSON.parse(tis);
- updateNodesStates(taskInstances);
+ taskInstances = JSON.parse(tis);
+ const states = Object.values(taskInstances).map((ti) => ti.state);
+ updateNodesStates(taskInstances);
+
+ // end refresh if all states are final
+ if (!states.some((state) => (
+ state === null
+ || state === 'running'
+ || state === 'scheduled'
+ || state === 'queued'
+ || state === 'up_for_retry'
+ || state === 'up_for_reschedule'
Review comment:
We should invert this -- there are fewer terminal states (and less chance of us adding any new ones - we added a new on in https://github.com/apache/airflow/pull/16681 for instance)
So something like
```suggestion
["success", "failed", "upstream_failed", "skipped", "removed"].indexOf(state) !== -1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16696: Improve graph view refresh
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16696:
URL: https://github.com/apache/airflow/pull/16696#discussion_r660520186
##########
File path: airflow/www/static/js/graph.js
##########
@@ -364,14 +364,34 @@ function setFocusMap(state) {
const stateIsSet = () => !!Object.keys(stateFocusMap).find((key) => stateFocusMap[key]);
+let prevTis;
+
function handleRefresh() {
$('#loading-dots').css('display', 'inline-block');
$.get(getTaskInstanceURL)
.done(
(tis) => {
+ // only refresh if the data has changed
+ if (prevTis !== tis) {
// eslint-disable-next-line no-global-assign
- taskInstances = JSON.parse(tis);
- updateNodesStates(taskInstances);
+ taskInstances = JSON.parse(tis);
+ const states = Object.values(taskInstances).map((ti) => ti.state);
+ updateNodesStates(taskInstances);
+
+ // end refresh if all states are final
+ if (!states.some((state) => (
+ state === null
+ || state === 'running'
+ || state === 'scheduled'
+ || state === 'queued'
+ || state === 'up_for_retry'
+ || state === 'up_for_reschedule'
Review comment:
We should invert this -- there are fewer terminal states (and less chance of us adding any new ones - we added a new on in https://github.com/apache/airflow/pull/16681 for instance)
So something like
```suggestion
["success", "failed", "upstream_failed", "skipped", "removed"].indexOf(state) !== -1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16696: Improve graph view refresh
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16696:
URL: https://github.com/apache/airflow/pull/16696#issuecomment-876035311
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #16696: Improve graph view refresh
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #16696:
URL: https://github.com/apache/airflow/pull/16696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org