You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/07 09:27:01 UTC
[GitHub] [flink] matriv opened a new pull request, #19387: [FLINK-27111][table][docs] Update docs regarding TableEnvironment configuration
matriv opened a new pull request, #19387:
URL: https://github.com/apache/flink/pull/19387
## What is the purpose of the change
Following the work on [FLINK-16835] update the docs accordingly to
mention the use of `EnvironmentSettings` and that `TableEnvironement`
related configuration can also be set in `flink-conf.yaml`.
## Brief change log
- Update docs for `TableEnvironment` configuration
- Update examples for instantiating `TableEnvironment` using `EnvironmentSettings`.
## Verifying this change
This change is only docs related without the need of any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **update docs**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19387: [FLINK-27111][table][docs] Update docs regarding TableEnvironment configuration
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19387:
URL: https://github.com/apache/flink/pull/19387#issuecomment-1091430877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b1e3ce7164c2d056aee30bf339a71ee923993cb9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b1e3ce7164c2d056aee30bf339a71ee923993cb9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b1e3ce7164c2d056aee30bf339a71ee923993cb9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a diff in pull request #19387: [FLINK-27111][table][docs] Update docs regarding TableEnvironment configuration
Posted by GitBox <gi...@apache.org>.
matriv commented on code in PR #19387:
URL: https://github.com/apache/flink/pull/19387#discussion_r844933371
##########
docs/content/docs/dev/table/config.md:
##########
@@ -96,6 +124,11 @@ Flink SQL> SET 'table.exec.mini-batch.size' = '5000';
{{< /tab >}}
{{< /tabs >}}
+**Note:** All of the following configuration options can also be set globally in
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a diff in pull request #19387: [FLINK-27111][table][docs] Update docs regarding TableEnvironment configuration
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on code in PR #19387:
URL: https://github.com/apache/flink/pull/19387#discussion_r844928458
##########
docs/content/docs/dev/table/config.md:
##########
@@ -96,6 +124,11 @@ Flink SQL> SET 'table.exec.mini-batch.size' = '5000';
{{< /tab >}}
{{< /tabs >}}
+**Note:** All of the following configuration options can also be set globally in
Review Comment:
Just a typography comment here: Use the hints here: https://github.com/apache/flink/tree/master/docs#info-hints
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19387: [FLINK-27111][table][docs] Update docs regarding TableEnvironment configuration
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19387:
URL: https://github.com/apache/flink/pull/19387#issuecomment-1092109461
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #19387: [FLINK-27111][table][docs] Update docs regarding TableEnvironment configuration
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #19387:
URL: https://github.com/apache/flink/pull/19387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #19387: [FLINK-27111][table][docs] Update docs regarding TableEnvironment configuration
Posted by GitBox <gi...@apache.org>.
matriv commented on PR #19387:
URL: https://github.com/apache/flink/pull/19387#issuecomment-1091633289
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org