You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/04/05 17:43:49 UTC

[GitHub] [hadoop] virajjasani commented on a change in pull request #2854: HDFS-15945. DataNodes with zero capacity and zero blocks should be decommissioned immediately.

virajjasani commented on a change in pull request #2854:
URL: https://github.com/apache/hadoop/pull/2854#discussion_r607104128



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
##########
@@ -4584,8 +4584,14 @@ void processExtraRedundancyBlocksOnInService(
    */
   boolean isNodeHealthyForDecommissionOrMaintenance(DatanodeDescriptor node) {
     if (!node.checkBlockReportReceived()) {
-      LOG.info("Node {} hasn't sent its first block report.", node);
-      return false;
+      if (node.getCapacity() == 0 && node.getNumBlocks() == 0) {

Review comment:
       Agree that due to storage problem, capacity and numBlocks both become 0 and we need to handle this case.
   But is it possible to have 0 numBlocks but capacity > 0 under any circumstances? Should we handle it if that is possible?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org