You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/07 13:49:11 UTC
[GitHub] [dubbo] AlbumenJ opened a new pull request #9228: [WIP][3.0] Refactor State Router
AlbumenJ opened a new pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228
## What is the purpose of the change
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#issuecomment-962629893
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9228](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4f4e88) into [3.0](https://codecov.io/gh/apache/dubbo/commit/8a14fb39304308c0b742dbc3fad60cdcc6595f6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a14fb3) will **decrease** coverage by `0.00%`.
> The diff coverage is `58.51%`.
[](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9228 +/- ##
============================================
- Coverage 64.73% 64.73% -0.01%
Complexity 329 329
============================================
Files 1206 1200 -6
Lines 51801 51577 -224
Branches 7715 7715
============================================
- Hits 33531 33386 -145
+ Misses 14654 14581 -73
+ Partials 3616 3610 -6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `65.11% <ø> (-0.80%)` | :arrow_down: |
| [...luster/router/condition/config/AppStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwU3RhdGVSb3V0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/dubbo/rpc/cluster/router/state/StateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3N0YXRlL1N0YXRlUm91dGVyLmphdmE=) | `50.00% <ø> (+21.42%)` | :arrow_up: |
| [...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0ZVJvdXRlci5qYXZh) | `28.43% <10.00%> (ø)` | |
| [...router/condition/config/ListenableStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVN0YXRlUm91dGVyLmphdmE=) | `30.76% <20.00%> (ø)` | |
| [...cluster/router/condition/ConditionStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25TdGF0ZVJvdXRlci5qYXZh) | `66.86% <47.36%> (ø)` | |
| [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `69.23% <70.00%> (ø)` | |
| [.../rpc/cluster/router/mock/MockInvokersSelector.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21vY2svTW9ja0ludm9rZXJzU2VsZWN0b3IuamF2YQ==) | `74.19% <71.42%> (-14.70%)` | :arrow_down: |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `70.76% <78.12%> (-6.60%)` | :arrow_down: |
| ... and [36 more](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8a14fb3...b4f4e88](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#issuecomment-962629893
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9228](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4f4e88) into [3.0](https://codecov.io/gh/apache/dubbo/commit/8a14fb39304308c0b742dbc3fad60cdcc6595f6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a14fb3) will **increase** coverage by `0.02%`.
> The diff coverage is `58.51%`.
[](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9228 +/- ##
============================================
+ Coverage 64.73% 64.75% +0.02%
Complexity 329 329
============================================
Files 1206 1200 -6
Lines 51801 51577 -224
Branches 7715 7715
============================================
- Hits 33531 33399 -132
+ Misses 14654 14567 -87
+ Partials 3616 3611 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `65.11% <ø> (-0.80%)` | :arrow_down: |
| [...luster/router/condition/config/AppStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwU3RhdGVSb3V0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/dubbo/rpc/cluster/router/state/StateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3N0YXRlL1N0YXRlUm91dGVyLmphdmE=) | `50.00% <ø> (+21.42%)` | :arrow_up: |
| [...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0ZVJvdXRlci5qYXZh) | `28.43% <10.00%> (ø)` | |
| [...router/condition/config/ListenableStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVN0YXRlUm91dGVyLmphdmE=) | `30.76% <20.00%> (ø)` | |
| [...cluster/router/condition/ConditionStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25TdGF0ZVJvdXRlci5qYXZh) | `66.86% <47.36%> (ø)` | |
| [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `69.23% <70.00%> (ø)` | |
| [.../rpc/cluster/router/mock/MockInvokersSelector.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21vY2svTW9ja0ludm9rZXJzU2VsZWN0b3IuamF2YQ==) | `74.19% <71.42%> (-14.70%)` | :arrow_down: |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `70.76% <78.12%> (-6.60%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8a14fb3...b4f4e88](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#issuecomment-962629893
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9228](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8eb74a9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/57ab318ee8be9aeb84ccfbae7a3ade1f4b0c5e27?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57ab318) will **decrease** coverage by `0.51%`.
> The diff coverage is `59.13%`.
[](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9228 +/- ##
============================================
- Coverage 65.40% 64.89% -0.52%
- Complexity 311 329 +18
============================================
Files 1188 1200 +12
Lines 51475 51521 +46
Branches 7694 7670 -24
============================================
- Hits 33668 33433 -235
- Misses 14177 14447 +270
- Partials 3630 3641 +11
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `66.66% <ø> (-0.73%)` | :arrow_down: |
| [...luster/router/condition/config/AppStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwU3RhdGVSb3V0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/dubbo/rpc/cluster/router/state/StateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3N0YXRlL1N0YXRlUm91dGVyLmphdmE=) | `33.33% <0.00%> (+4.76%)` | :arrow_up: |
| [...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0ZVJvdXRlci5qYXZh) | `29.47% <7.69%> (ø)` | |
| [...router/condition/config/ListenableStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVN0YXRlUm91dGVyLmphdmE=) | `29.41% <14.28%> (ø)` | |
| [...cluster/router/condition/ConditionStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25TdGF0ZVJvdXRlci5qYXZh) | `66.66% <33.33%> (ø)` | |
| [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `68.62% <66.66%> (ø)` | |
| [.../rpc/cluster/router/mock/MockInvokersSelector.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21vY2svTW9ja0ludm9rZXJzU2VsZWN0b3IuamF2YQ==) | `76.92% <75.00%> (-11.97%)` | :arrow_down: |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `70.76% <78.12%> (-6.60%)` | :arrow_down: |
| ... and [112 more](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [57ab318...8eb74a9](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#issuecomment-962629893
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9228](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4f4e88) into [3.0](https://codecov.io/gh/apache/dubbo/commit/8a14fb39304308c0b742dbc3fad60cdcc6595f6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a14fb3) will **decrease** coverage by `0.08%`.
> The diff coverage is `59.64%`.
[](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9228 +/- ##
============================================
- Coverage 64.73% 64.64% -0.09%
Complexity 329 329
============================================
Files 1206 1200 -6
Lines 51801 51520 -281
Branches 7715 7662 -53
============================================
- Hits 33531 33305 -226
+ Misses 14654 14591 -63
- Partials 3616 3624 +8
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `65.11% <ø> (-0.80%)` | :arrow_down: |
| [...luster/router/condition/config/AppStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwU3RhdGVSb3V0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/dubbo/rpc/cluster/router/state/StateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3N0YXRlL1N0YXRlUm91dGVyLmphdmE=) | `50.00% <ø> (+21.42%)` | :arrow_up: |
| [...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0ZVJvdXRlci5qYXZh) | `29.47% <7.69%> (ø)` | |
| [...router/condition/config/ListenableStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVN0YXRlUm91dGVyLmphdmE=) | `29.41% <14.28%> (ø)` | |
| [...cluster/router/condition/ConditionStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25TdGF0ZVJvdXRlci5qYXZh) | `66.66% <33.33%> (ø)` | |
| [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `68.62% <66.66%> (ø)` | |
| [.../rpc/cluster/router/mock/MockInvokersSelector.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21vY2svTW9ja0ludm9rZXJzU2VsZWN0b3IuamF2YQ==) | `76.92% <75.00%> (-11.97%)` | :arrow_down: |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `70.76% <78.12%> (-6.60%)` | :arrow_down: |
| ... and [61 more](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8a14fb3...b4f4e88](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#issuecomment-962629893
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9228](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8eb74a9) into [3.0](https://codecov.io/gh/apache/dubbo/commit/57ab318ee8be9aeb84ccfbae7a3ade1f4b0c5e27?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57ab318) will **decrease** coverage by `0.47%`.
> The diff coverage is `58.08%`.
[](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9228 +/- ##
============================================
- Coverage 65.40% 64.92% -0.48%
- Complexity 311 329 +18
============================================
Files 1188 1200 +12
Lines 51475 51578 +103
Branches 7694 7725 +31
============================================
- Hits 33668 33489 -179
- Misses 14177 14459 +282
Partials 3630 3630
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `66.66% <ø> (-0.73%)` | :arrow_down: |
| [...luster/router/condition/config/AppStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwU3RhdGVSb3V0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/dubbo/rpc/cluster/router/state/StateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3N0YXRlL1N0YXRlUm91dGVyLmphdmE=) | `33.33% <0.00%> (+4.76%)` | :arrow_up: |
| [...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0ZVJvdXRlci5qYXZh) | `28.43% <10.00%> (ø)` | |
| [...router/condition/config/ListenableStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVN0YXRlUm91dGVyLmphdmE=) | `30.76% <20.00%> (ø)` | |
| [...cluster/router/condition/ConditionStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25TdGF0ZVJvdXRlci5qYXZh) | `66.86% <47.36%> (ø)` | |
| [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `69.23% <70.00%> (ø)` | |
| [.../rpc/cluster/router/mock/MockInvokersSelector.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21vY2svTW9ja0ludm9rZXJzU2VsZWN0b3IuamF2YQ==) | `74.19% <71.42%> (-14.70%)` | :arrow_down: |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `70.76% <78.12%> (-6.60%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [57ab318...8eb74a9](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] guohao commented on a change in pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
guohao commented on a change in pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#discussion_r744445790
##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/state/StateRouter.java
##########
@@ -57,7 +54,7 @@
* @Since 3.0
Review comment:
```suggestion
* @since 3.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#issuecomment-962629893
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9228](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4f4e88) into [3.0](https://codecov.io/gh/apache/dubbo/commit/8a14fb39304308c0b742dbc3fad60cdcc6595f6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a14fb3) will **decrease** coverage by `0.02%`.
> The diff coverage is `58.51%`.
[](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9228 +/- ##
============================================
- Coverage 64.73% 64.70% -0.03%
Complexity 329 329
============================================
Files 1206 1200 -6
Lines 51801 51577 -224
Branches 7715 7715
============================================
- Hits 33531 33371 -160
+ Misses 14654 14594 -60
+ Partials 3616 3612 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `65.11% <ø> (-0.80%)` | :arrow_down: |
| [...luster/router/condition/config/AppStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwU3RhdGVSb3V0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/dubbo/rpc/cluster/router/state/StateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3N0YXRlL1N0YXRlUm91dGVyLmphdmE=) | `50.00% <ø> (+21.42%)` | :arrow_up: |
| [...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0ZVJvdXRlci5qYXZh) | `28.43% <10.00%> (ø)` | |
| [...router/condition/config/ListenableStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVN0YXRlUm91dGVyLmphdmE=) | `30.76% <20.00%> (ø)` | |
| [...cluster/router/condition/ConditionStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25TdGF0ZVJvdXRlci5qYXZh) | `66.86% <47.36%> (ø)` | |
| [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `69.23% <70.00%> (ø)` | |
| [.../rpc/cluster/router/mock/MockInvokersSelector.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21vY2svTW9ja0ludm9rZXJzU2VsZWN0b3IuamF2YQ==) | `74.19% <71.42%> (-14.70%)` | :arrow_down: |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `70.76% <78.12%> (-6.60%)` | :arrow_down: |
| ... and [41 more](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8a14fb3...b4f4e88](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#issuecomment-962629893
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9228](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03bc3a0) into [3.0](https://codecov.io/gh/apache/dubbo/commit/57ab318ee8be9aeb84ccfbae7a3ade1f4b0c5e27?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57ab318) will **decrease** coverage by `0.41%`.
> The diff coverage is `67.52%`.
[](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9228 +/- ##
============================================
- Coverage 65.40% 64.98% -0.42%
- Complexity 311 327 +16
============================================
Files 1188 1200 +12
Lines 51475 51558 +83
Branches 7694 7698 +4
============================================
- Hits 33668 33506 -162
- Misses 14177 14427 +250
+ Partials 3630 3625 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `66.66% <ø> (-0.73%)` | :arrow_down: |
| [...luster/router/condition/config/AppStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwU3RhdGVSb3V0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/dubbo/rpc/cluster/router/state/StateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3N0YXRlL1N0YXRlUm91dGVyLmphdmE=) | `33.33% <0.00%> (+4.76%)` | :arrow_up: |
| [...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0ZVJvdXRlci5qYXZh) | `28.71% <10.52%> (ø)` | |
| [...router/condition/config/ListenableStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVN0YXRlUm91dGVyLmphdmE=) | `36.36% <50.00%> (ø)` | |
| [...cluster/router/condition/ConditionStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25TdGF0ZVJvdXRlci5qYXZh) | `69.75% <75.00%> (ø)` | |
| [.../rpc/cluster/router/mock/MockInvokersSelector.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21vY2svTW9ja0ludm9rZXJzU2VsZWN0b3IuamF2YQ==) | `76.66% <75.00%> (-12.23%)` | :arrow_down: |
| [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `70.58% <77.77%> (ø)` | |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `70.76% <78.12%> (-6.60%)` | :arrow_down: |
| ... and [71 more](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [57ab318...03bc3a0](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#issuecomment-962629893
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9228](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03bc3a0) into [3.0](https://codecov.io/gh/apache/dubbo/commit/57ab318ee8be9aeb84ccfbae7a3ade1f4b0c5e27?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57ab318) will **decrease** coverage by `0.43%`.
> The diff coverage is `67.52%`.
[](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9228 +/- ##
============================================
- Coverage 65.40% 64.96% -0.44%
- Complexity 311 326 +15
============================================
Files 1188 1200 +12
Lines 51475 51558 +83
Branches 7694 7698 +4
============================================
- Hits 33668 33497 -171
- Misses 14177 14435 +258
+ Partials 3630 3626 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `66.66% <ø> (-0.73%)` | :arrow_down: |
| [...luster/router/condition/config/AppStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwU3RhdGVSb3V0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/dubbo/rpc/cluster/router/state/StateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3N0YXRlL1N0YXRlUm91dGVyLmphdmE=) | `33.33% <0.00%> (+4.76%)` | :arrow_up: |
| [...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0ZVJvdXRlci5qYXZh) | `28.71% <10.52%> (ø)` | |
| [...router/condition/config/ListenableStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVN0YXRlUm91dGVyLmphdmE=) | `36.36% <50.00%> (ø)` | |
| [...cluster/router/condition/ConditionStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25TdGF0ZVJvdXRlci5qYXZh) | `69.75% <75.00%> (ø)` | |
| [.../rpc/cluster/router/mock/MockInvokersSelector.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21vY2svTW9ja0ludm9rZXJzU2VsZWN0b3IuamF2YQ==) | `76.66% <75.00%> (-12.23%)` | :arrow_down: |
| [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `70.58% <77.77%> (ø)` | |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `70.76% <78.12%> (-6.60%)` | :arrow_down: |
| ... and [73 more](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [57ab318...03bc3a0](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] guohao commented on a change in pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
guohao commented on a change in pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#discussion_r744443551
##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/state/StateRouter.java
##########
@@ -91,10 +83,20 @@
*/
boolean isRuntime();
- boolean isEnable();
-
+ /**
+ * To decide whether this router should take effect when none of the invoker can match the router rule, which
+ * means the {@link #route(BitList, URL, Invocation, boolean)} would be empty. Most of time, most router implementation would
+ * default this value to false.
+ *
+ * @return true to execute if none of invokers matches the current router
+ */
Review comment:
`isForce` is not a common logic in `AbstractRouter`, can it be removed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#issuecomment-962629893
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9228](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03bc3a0) into [3.0](https://codecov.io/gh/apache/dubbo/commit/57ab318ee8be9aeb84ccfbae7a3ade1f4b0c5e27?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57ab318) will **decrease** coverage by `0.50%`.
> The diff coverage is `67.52%`.
[](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9228 +/- ##
============================================
- Coverage 65.40% 64.90% -0.51%
- Complexity 311 326 +15
============================================
Files 1188 1200 +12
Lines 51475 51558 +83
Branches 7694 7662 -32
============================================
- Hits 33668 33464 -204
- Misses 14177 14459 +282
- Partials 3630 3635 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `66.66% <ø> (-0.73%)` | :arrow_down: |
| [...luster/router/condition/config/AppStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwU3RhdGVSb3V0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/dubbo/rpc/cluster/router/state/StateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3N0YXRlL1N0YXRlUm91dGVyLmphdmE=) | `33.33% <0.00%> (+4.76%)` | :arrow_up: |
| [...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0ZVJvdXRlci5qYXZh) | `28.71% <10.52%> (ø)` | |
| [...router/condition/config/ListenableStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVN0YXRlUm91dGVyLmphdmE=) | `36.36% <50.00%> (ø)` | |
| [...cluster/router/condition/ConditionStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25TdGF0ZVJvdXRlci5qYXZh) | `69.75% <75.00%> (ø)` | |
| [.../rpc/cluster/router/mock/MockInvokersSelector.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21vY2svTW9ja0ludm9rZXJzU2VsZWN0b3IuamF2YQ==) | `76.66% <75.00%> (-12.23%)` | :arrow_down: |
| [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `70.58% <77.77%> (ø)` | |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `70.76% <78.12%> (-6.60%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [57ab318...03bc3a0](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9228: [3.0] Refactor State Router
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#issuecomment-962629893
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9228](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83be458) into [3.0](https://codecov.io/gh/apache/dubbo/commit/8a14fb39304308c0b742dbc3fad60cdcc6595f6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a14fb3) will **decrease** coverage by `0.04%`.
> The diff coverage is `60.41%`.
[](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9228 +/- ##
============================================
- Coverage 64.73% 64.68% -0.05%
+ Complexity 329 328 -1
============================================
Files 1206 1200 -6
Lines 51801 51619 -182
Branches 7715 7715
============================================
- Hits 33531 33388 -143
+ Misses 14654 14621 -33
+ Partials 3616 3610 -6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...luster/router/condition/config/AppStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvQXBwU3RhdGVSb3V0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cluster/router/condition/config/ServiceRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvU2VydmljZVJvdXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/dubbo/rpc/cluster/router/state/StateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3N0YXRlL1N0YXRlUm91dGVyLmphdmE=) | `50.00% <ø> (+21.42%)` | :arrow_up: |
| [...e/dubbo/rpc/cluster/router/tag/TagStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0ZVJvdXRlci5qYXZh) | `28.43% <10.00%> (ø)` | |
| [...router/condition/config/ListenableStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvTGlzdGVuYWJsZVN0YXRlUm91dGVyLmphdmE=) | `30.76% <20.00%> (ø)` | |
| [...cluster/router/condition/ConditionStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9Db25kaXRpb25TdGF0ZVJvdXRlci5qYXZh) | `66.86% <47.36%> (ø)` | |
| [...o/rpc/cluster/router/script/ScriptStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3NjcmlwdC9TY3JpcHRTdGF0ZVJvdXRlci5qYXZh) | `69.23% <70.00%> (ø)` | |
| [.../rpc/cluster/router/mock/MockInvokersSelector.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21vY2svTW9ja0ludm9rZXJzU2VsZWN0b3IuamF2YQ==) | `74.19% <71.42%> (-14.70%)` | :arrow_down: |
| [...java/org/apache/dubbo/rpc/cluster/RouterChain.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvUm91dGVyQ2hhaW4uamF2YQ==) | `70.76% <77.77%> (-6.60%)` | :arrow_down: |
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `65.11% <100.00%> (-0.80%)` | :arrow_down: |
| ... and [43 more](https://codecov.io/gh/apache/dubbo/pull/9228/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8a14fb3...83be458](https://codecov.io/gh/apache/dubbo/pull/9228?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org