You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/02 11:23:00 UTC

[jira] [Commented] (TINKERPOP-1756) Provide a way to easily mock a RemoteConnection for tests

    [ https://issues.apache.org/jira/browse/TINKERPOP-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151481#comment-16151481 ] 

ASF GitHub Bot commented on TINKERPOP-1756:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/703

    TINKERPOP-1756 Added an EmbeddedRemoteConnection.

    https://issues.apache.org/jira/browse/TINKERPOP-1756
    
    This enables a "remote" to be mocked so as to be run locally in the same JVM. Not sure if there are other applications for this.
    
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1756

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/703.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #703
    
----
commit e1f64b4afc4f297bef2a72f99ac258d774a1fbff
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-09-01T19:42:20Z

    TINKERPOP-1756 Added an EmbeddedRemoteConnection.
    
    This enables a "remote" to be mocked to actually run locally in the same JVM.

----


> Provide a way to easily mock a RemoteConnection for tests
> ---------------------------------------------------------
>
>                 Key: TINKERPOP-1756
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1756
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.4
>            Reporter: Anish Doshi
>
> {{org.apache.tinkerpop.gremlin.driver.Cluster}} is currently a final class. Which means that every time I need to mock this class, I cannot. I have to create a separate object and mock that object instead of mocking {{Cluster}}.
> Is there a chance that Cluster can be changed to an interface, or at least not have as a {{final}} class?
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)