You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/16 19:15:16 UTC

[GitHub] [arrow] jorgecarleitao opened a new pull request #8942: ARROW-10946: [Rust] Simplified bit chunk iterator

jorgecarleitao opened a new pull request #8942:
URL: https://github.com/apache/arrow/pull/8942


   This PR makes the bit chunk iterator not depend on a `Buffer`, since we were only using it to keep track of the lifetime, and we can just use a byte slice for it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nevi-me closed pull request #8942: ARROW-10946: [Rust] Simplified bit chunk iterator

Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #8942:
URL: https://github.com/apache/arrow/pull/8942


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jhorstmann commented on pull request #8942: ARROW-10946: [Rust] Simplified bit chunk iterator

Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #8942:
URL: https://github.com/apache/arrow/pull/8942#issuecomment-748107342


   Looks good :+1: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan commented on pull request #8942: ARROW-10946: [Rust] Simplified bit chunk iterator

Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #8942:
URL: https://github.com/apache/arrow/pull/8942#issuecomment-746912070


   LGTM 👍  I like the simplification. Any (expected) change in performance?
   
   I think the CI is failing because of a change for parquet that was just reverted. So I guess it will just succeed in the new run.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #8942: ARROW-10946: [Rust] Simplified bit chunk iterator

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8942:
URL: https://github.com/apache/arrow/pull/8942#issuecomment-748445822


   > Any (expected) change in performance?
   
   Nop, `slice.as_ptr()` is constant, which is the only call that was changed on the iteration.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8942: ARROW-10946: [Rust] Simplified bit chunk iterator

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8942:
URL: https://github.com/apache/arrow/pull/8942#issuecomment-746876449


   https://issues.apache.org/jira/browse/ARROW-10946


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org