[GitHub] [arrow] dragosmg commented on a change in pull request #12431: ARROW-14826 [R] Implement bindings for `lubridate::dst()`

[GitBox <gi...@apache.org>]

dragosmg commented on a change in pull request #12431:
URL: https://github.com/apache/arrow/pull/12431#discussion_r808242823



##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -711,3 +711,17 @@ test_that("am/pm mirror lubridate", {
   )
 
 })
+test_that("dst extracts daylight savings time correctly", {
+  test_df <- tibble(
+    dates = as.POSIXct(c("2021-02-20", "2021-07-31", "2021-10-31", "2021-01-31"), tz = "Europe/London")
+  )
+  # https://issues.apache.org/jira/browse/ARROW-13168
+  skip_on_os("windows")
+
+  compare_dplyr_binding(
+    .input %>%
+      mutate(dst = dst(dates)) %>%
+      collect(),
+    test_df
+  )

Review comment:
       I'm all for testing behaviour with unsupported inputs, but how many types is enough? Do we want unit tests for all of them?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org