You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/08 15:24:19 UTC
[GitHub] [spark] szhem commented on a change in pull request #24556:
[SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly
szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix MetricsSystem to remove unregistered source correctly
URL: https://github.com/apache/spark/pull/24556#discussion_r282118028
##########
File path: core/src/main/scala/org/apache/spark/metrics/source/AccumulatorSource.scala
##########
@@ -64,10 +64,11 @@ class DoubleAccumulatorSource extends AccumulatorSource
*/
Review comment:
Changes in this file seems to be not necessary if removing metrics by exact match from the shared registry as described above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org