[jira] [Commented] (MAPREDUCE-2573) New findbugs warning after MAPREDUCE-2494

["Robert Joseph Evans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045959#comment-13045959 ] 

Robert Joseph Evans commented on MAPREDUCE-2573:
------------------------------------------------

I am not sure why this issue is showing up now because MAPREDUCE-2494 did not modify that part of the code, but it is correct that it should be a static inner class.  The change is simple to do, I should have a patch for it very shortly.

> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
>                 Key: MAPREDUCE-2573
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Todd Lipcon
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it.  This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary.  If possible, the class should be made static.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira