You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/08/23 18:28:36 UTC
[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4096
Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................
IMPALA-3832: test invalid data handling in lzo text scanner
This adds the lzo text scanner to the fuzz testing.
I ran the test in a loop under ASAN overnight and didn't see any
failures.
Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/4096/1
--
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4096/3/tests/query_test/test_scanners_fuzz.py
File tests/query_test/test_scanners_fuzz.py:
PS3, Line 143: corrupt LZO index file
should we file a JIRA for this? technically we should skip the file when abort_on_error=0 in this case, right?
--
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................
Patch Set 4: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................
IMPALA-3832: test invalid data handling in lzo text scanner
This adds the lzo text scanner to the fuzz testing.
I ran the test in a loop under ASAN overnight and didn't see any
failures.
Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 16 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/4096/3
--
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4096/3/tests/query_test/test_scanners_fuzz.py
File tests/query_test/test_scanners_fuzz.py:
PS3, Line 143: corrupt LZO index file
> should we file a JIRA for this? technically we should skip the file when a
Done
--
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4096
to look at the new patch set (#4).
Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................
IMPALA-3832: test invalid data handling in lzo text scanner
This adds the lzo text scanner to the fuzz testing.
I ran the test in a loop under ASAN overnight and didn't see any
failures.
Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 17 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/4096/4
--
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4096/2/tests/query_test/test_scanners_fuzz.py
File tests/query_test/test_scanners_fuzz.py:
Line 61: pytest.skip()
> why?
We don't have decimal_tbl for these file formats. Added comment.
Line 144: table_format.compression_codec != 'none'):
> what errors do we produce?
Good point. I see a lot of:
Error while reading index file: hdfs://localhost:20500/test-warehouse/test_fuzz_alltypes_c35099ab.db/alltypes/year=2010/month=2/000022_0.lzo.index
Updated comment
--
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4096/2/tests/query_test/test_scanners_fuzz.py
File tests/query_test/test_scanners_fuzz.py:
Line 61: pytest.skip()
why?
Line 144: table_format.compression_codec != 'none'):
what errors do we produce?
--
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................
IMPALA-3832: test invalid data handling in lzo text scanner
This adds the lzo text scanner to the fuzz testing.
I ran the test in a loop under ASAN overnight and didn't see any
failures.
Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Reviewed-on: http://gerrit.cloudera.org:8080/4096
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 17 insertions(+), 8 deletions(-)
Approvals:
Internal Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>