You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/12/06 22:49:36 UTC

[GitHub] [bookkeeper] nicoloboschi opened a new issue #2930: Enable backward-compatibility tests

nicoloboschi opened a new issue #2930:
URL: https://github.com/apache/bookkeeper/issues/2930


   Currently, building BookKeeper with Maven doesn't trigger the tests under `tests/backward-compat`. (neither with `-PintegrationTests` and `-DintegrationTests` 
   With Gradle these tests run in the test phase but they fail due to timeout while connecting to ZK container.
   
   We need to
   1) make sure the tests are run during build (both Maven and Gradle)
   2) fix all the tests
   
   I will start a discussion on dev@ for moving to TestContainers and remove the Arquillian Cube framework from the codebase.
   
   This will lead to:
   1. Add test-containers setup; starts ZK and _n_ bookie containers (upgrading ZK container to the current used version by BK)
   2. Remove Arquillian Cube dependency and setup files (arquillian.xml)
   3. Put together all these tests in a single module to increase readability - code reusability - decrease verbosity
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] nicoloboschi closed issue #2930: Enable backward-compatibility tests

Posted by GitBox <gi...@apache.org>.
nicoloboschi closed issue #2930:
URL: https://github.com/apache/bookkeeper/issues/2930


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] hsaputra commented on issue #2930: Enable backward-compatibility tests

Posted by GitBox <gi...@apache.org>.
hsaputra commented on issue #2930:
URL: https://github.com/apache/bookkeeper/issues/2930#issuecomment-990372553


   FYI @Vanlightly , @pkumar-singh , @ivankelly 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] pkumar-singh commented on issue #2930: Enable backward-compatibility tests

Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on issue #2930:
URL: https://github.com/apache/bookkeeper/issues/2930#issuecomment-990406057


   @nicoloboschi Very good idea. Giving some pointers. We are already using gradle to run integration tests with test container. Kindly see If you can lift something from there and reuse.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org