You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/29 01:15:07 UTC

[GitHub] [shardingsphere] xbkaishui opened a new pull request #6202: Support local datetime

xbkaishui opened a new pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202


   Fixes #6166.
   
   Changes proposed in this pull request:
   -
   -
   -
   support local datetime 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-718364225


   I suppose the release time will be in next week. :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] EcoRIIHC commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
EcoRIIHC commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-717666369


   > you should use the master branch.
   
   why not update maven repo?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#discussion_r446829056



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/resultset/ShardingSphereResultSet.java
##########
@@ -17,6 +17,10 @@
 
 package org.apache.shardingsphere.driver.jdbc.core.resultset;
 
+import java.sql.SQLFeatureNotSupportedException;

Review comment:
       Add test case in ShardingSphereResultSetTest

##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/resultset/ResultSetUtil.java
##########
@@ -20,6 +20,10 @@
 import com.google.common.primitives.Ints;
 import com.google.common.primitives.Longs;
 import com.google.common.primitives.Shorts;
+import java.time.LocalDate;

Review comment:
       Add test case in ResultSetUtilTest




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] xbkaishui commented on a change in pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#discussion_r446799528



##########
File path: .gitignore
##########
@@ -35,3 +35,4 @@ logs/
 # system ignore
 .DS_Store
 Thumbs.db
+*.factorypath

Review comment:
       ok, will remove it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] xbkaishui commented on a change in pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#discussion_r446780532



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/resultset/ShardingSphereResultSet.java
##########
@@ -372,4 +376,21 @@ public Object getObject(final String columnLabel) throws SQLException {
         int columnIndex = columnLabelAndIndexMap.get(columnLabel);
         return mergeResultSet.getValue(columnIndex, Object.class);
     }
+
+    @Override
+    public <T> T getObject(final int columnIndex, final Class<T> type) throws SQLException {

Review comment:
       good point. I will add more type support in another  pull request 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] xbkaishui commented on a change in pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#discussion_r446779465



##########
File path: .gitignore
##########
@@ -35,3 +35,4 @@ logs/
 # system ignore
 .DS_Store
 Thumbs.db
+*.factorypath

Review comment:
       this is auto generate by import, not related to this project. should I unignore it ? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] EcoRIIHC commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
EcoRIIHC commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-717657681


   latest version in maven repo still not support ? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#discussion_r446772712



##########
File path: .gitignore
##########
@@ -35,3 +35,4 @@ logs/
 # system ignore
 .DS_Store
 Thumbs.db
+*.factorypath

Review comment:
       Why should we add this one?

##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/resultset/ShardingSphereResultSet.java
##########
@@ -372,4 +376,21 @@ public Object getObject(final String columnLabel) throws SQLException {
         int columnIndex = columnLabelAndIndexMap.get(columnLabel);
         return mergeResultSet.getValue(columnIndex, Object.class);
     }
+
+    @Override
+    public <T> T getObject(final int columnIndex, final Class<T> type) throws SQLException {

Review comment:
       Is it possible to support more types?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] xbkaishui commented on a change in pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#discussion_r446799373



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/resultset/ShardingSphereResultSet.java
##########
@@ -372,4 +376,21 @@ public Object getObject(final String columnLabel) throws SQLException {
         int columnIndex = columnLabelAndIndexMap.get(columnLabel);
         return mergeResultSet.getValue(columnIndex, Object.class);
     }
+
+    @Override
+    public <T> T getObject(final int columnIndex, final Class<T> type) throws SQLException {

Review comment:
       ok, will remove it 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] xbkaishui commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-717668248


   Has not been released ..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-816436587


   @alterhu2020 Sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] EcoRIIHC commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
EcoRIIHC commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-717673147


   > Has not been released ..
   
   fine, got a plan ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] xbkaishui commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-717711869


   @tristaZero , Do we have a plan to release 5.0 ? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] xbkaishui commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-717662132


   you should use the master branch. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tuohai666 merged pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] xbkaishui commented on a change in pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#discussion_r446850957



##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/resultset/ResultSetUtil.java
##########
@@ -20,6 +20,10 @@
 import com.google.common.primitives.Ints;
 import com.google.common.primitives.Longs;
 import com.google.common.primitives.Shorts;
+import java.time.LocalDate;

Review comment:
       done

##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/resultset/ShardingSphereResultSet.java
##########
@@ -17,6 +17,10 @@
 
 package org.apache.shardingsphere.driver.jdbc.core.resultset;
 
+import java.sql.SQLFeatureNotSupportedException;

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#discussion_r446785021



##########
File path: .gitignore
##########
@@ -35,3 +35,4 @@ logs/
 # system ignore
 .DS_Store
 Thumbs.db
+*.factorypath

Review comment:
       I prefer remove it if this kind of files don't exist in project.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-835800015


   Hi 5.0.0-alpha is waiting for you, isn't it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] JasonMing commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
JasonMing commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-837955373


   But 5.0.0 is a **major** version upgrade, we have to re-examine all of the compatibility issues, cost too expensive to make the decision for managers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] JasonMing commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
JasonMing commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-835403290


   I cannot find any releases on maven central repo.
   The latest stable version is still 4.1.1.
   Can anyone release a patch version to fix this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] alterhu2020 commented on pull request #6202: Support local datetime

Posted by GitBox <gi...@apache.org>.
alterhu2020 commented on pull request #6202:
URL: https://github.com/apache/shardingsphere/pull/6202#issuecomment-816333895


   Does this release now ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org