[jira] Updated: (DERBY-1001) Rewrite 'store/encryptionKey.sql' to a JUnit test

["Kristian Waagan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-1001:
-----------------------------------

    Attachment: derby-1001-2a.stat
                derby-1001-2a.diff

Attached 'derby-1001-2a.diff' for review/commit.

I made the test rely on SupportFileSetup for cleaning up all the databases (deleting them), and added subclasses for three algorithms; AES, DES, Blowfish. I have no plans for adding more algorithms or variations atm. A run of store._Suite takes around 30 seconds on my machine.

I'll commit the patch next week unless I get pushback.

> Rewrite 'store/encryptionKey.sql' to a JUnit test
> -------------------------------------------------
>
>                 Key: DERBY-1001
>                 URL: https://issues.apache.org/jira/browse/DERBY-1001
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-1001-1a-preliminary.diff, derby-1001-1a-preliminary.stat, derby-1001-2a.diff, derby-1001-2a.stat
>
>
> This test has failed on Solaris10 for a long time, due to issues with the default security provider on this OS. See DERBY-788 for details.
> I consider rewriting this test as interresting because it allows us to see how things can be done in "the JUnit way". 
> 1) Run test with multiple encryption algorithms with minimal test code duplication.
> 2) Special handling of exceptions for specific providers (PCKS11-Solaris).
> The rewritten test might cause some discussion on how we want to handle the issues mentioned above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.