[GitHub] Mogball opened a new pull request #3458: Fixed filter removal bug

[gi...@git.apache.org]

Mogball opened a new pull request #3458: Fixed filter removal bug
URL: https://github.com/apache/incubator-superset/pull/3458
 
 
   To fix issue https://github.com/apache/incubator-superset/issues/3172 and a few other UI bugs with the slice filter.
   
   - Having multiple filters then removing a filter by clicking "-" would clear the filter selections for those below on the UI
   - Due to filter selection choices stored in `Filter` components as state, which are not updated when removing a filter
   - Changing filter operator from type of `array` to `string` or vice versa does not properly transform the currently selected values
   - Changing the filter column keeps the previously selected choices
   
   Solutions
   
   - Filter choices are stored as an array in the `FilterControl` component state and modified as filters are added, removed, or changed
   - These choices are passed down to `Filter` components as props
   - When changing the filter column, the selection values are cleared as per their type (array or string)
   - Changing filter operator properly converts between `array` and `string` as needed
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services