You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2020/04/27 09:12:21 UTC
[tomcat] branch 7.0.x updated: optimized code,
replace some c-style array
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new 9af6dc9 optimized code,replace some c-style array
9af6dc9 is described below
commit 9af6dc92a2e2e86c12c825b12c075f44bd81afa9
Author: xavier <12...@qq.com>
AuthorDate: Sun Apr 26 12:19:44 2020 +0800
optimized code,replace some c-style array
---
.../tomcat/jdbc/naming/GenericNamingResourcesFactory.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java b/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java
index 7af82f7..a4ef41c 100644
--- a/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java
+++ b/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/GenericNamingResourcesFactory.java
@@ -83,13 +83,13 @@ public class GenericNamingResourcesFactory implements ObjectFactory {
String setter = "set" + capitalize(name);
try {
- Method methods[] = o.getClass().getMethods();
+ Method[] methods = o.getClass().getMethods();
Method setPropertyMethodVoid = null;
Method setPropertyMethodBool = null;
// First, the ideal case - a setFoo( String ) method
for (int i = 0; i < methods.length; i++) {
- Class<?> paramT[] = methods[i].getParameterTypes();
+ Class<?>[] paramT = methods[i].getParameterTypes();
if (setter.equals(methods[i].getName()) && paramT.length == 1
&& "java.lang.String".equals(paramT[0].getName())) {
@@ -106,7 +106,7 @@ public class GenericNamingResourcesFactory implements ObjectFactory {
// match - find the type and invoke it
Class<?> paramType = methods[i].getParameterTypes()[0];
- Object params[] = new Object[1];
+ Object[] params = new Object[1];
// Try a setFoo ( int )
if ("java.lang.Integer".equals(paramType.getName())
@@ -167,7 +167,7 @@ public class GenericNamingResourcesFactory implements ObjectFactory {
// Ok, no setXXX found, try a setProperty("name", "value")
if (setPropertyMethodBool != null || setPropertyMethodVoid != null) {
- Object params[] = new Object[2];
+ Object[] params = new Object[2];
params[0] = name;
params[1] = value;
if (setPropertyMethodBool != null) {
@@ -218,7 +218,7 @@ public class GenericNamingResourcesFactory implements ObjectFactory {
if (name == null || name.length() == 0) {
return name;
}
- char chars[] = name.toCharArray();
+ char[] chars = name.toCharArray();
chars[0] = Character.toUpperCase(chars[0]);
return new String(chars);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org