You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2018/10/19 07:19:22 UTC

[GitHub] cziegeler commented on issue #13: SLING-8038 - Allow the Repository MOJO specify including features from CLI

cziegeler commented on issue #13: SLING-8038 - Allow the Repository MOJO specify including features from CLI
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/13#issuecomment-431268901
 
 
   It's a little bit hard to follow what exactly has changed. Maybe you could redo the patch without moving code out of the existing class first. We can later on then rename this class to AbstractXYZ
   The new mojo should not be bound to any lifecycle phase, otherwise it's not usable outside of a maven project. 
   In addition the only parameter it should get are mvn coordinates for the feature, no includes, no directory etc.
   The mvn coordinates can be parsed with the existing code in ArtifactId 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services