You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2023/05/03 16:24:15 UTC
[GitHub] [solr] epugh opened a new pull request, #1623: SOLR-16782: Export tool should export in JSON that matches Solr Import Format
epugh opened a new pull request, #1623:
URL: https://github.com/apache/solr/pull/1623
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Export tool only supports Javabin and JSONL, not JSON... We would like to have that to be able to import docs directly!
# Solution
Add JSON format... Make it the default format as JSONL is somewhat special purpose...
# Tests
extended existing tests.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1623: SOLR-16782: Export tool should export in JSON that matches Solr Import Format
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1623:
URL: https://github.com/apache/solr/pull/1623#issuecomment-1533612459
@janhoy I spiked out JSONL for solr streaming expressions... SO you can split the big doc and have multiple loaders all running ;-) For similar reasons... I had an interesting conversation with Christopher Ball about this at Haystack ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1623: SOLR-16782: Export tool should export in JSON that matches Solr Import Format
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1623:
URL: https://github.com/apache/solr/pull/1623#issuecomment-1533532071
Did not review, but makes sense.
However, for huuuge exports, jsonl makes sense since it is much easier to parse/stream line by line and won’t kill your editor. Probably solr’s json loader handles normal json in efficient way. But would be just as interesting to add support for jsonl to /update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1623: SOLR-16782: Export tool should export in JSON that matches Solr Import Format
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #1623:
URL: https://github.com/apache/solr/pull/1623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1623: SOLR-16782: Export tool should export in JSON that matches Solr Import Format
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1623:
URL: https://github.com/apache/solr/pull/1623#issuecomment-1533515916
Okay, I think this is ready for review.. With slicked up examples in ref guide. I tested the round tripping...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org