You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/31 13:28:08 UTC
[GitHub] [flink] wuchong commented on a change in pull request #12146: [FLINK-17968][hbase] Fix Hadoop Configuration is not properly serialized in HBaseRowInputFormat
wuchong commented on a change in pull request #12146:
URL: https://github.com/apache/flink/pull/12146#discussion_r432946967
##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/source/AbstractTableInputFormat.java
##########
@@ -99,6 +108,14 @@
*/
public abstract void configure(Configuration parameters);
+ protected void setSerializedConfig(org.apache.hadoop.conf.Configuration hConf) {
+ serializedConfig = HBaseConfigurationUtil.serializeConfiguration(hConf);
+ }
+
+ protected org.apache.hadoop.conf.Configuration getSerializedConfig() {
Review comment:
How about to call it `getHadoopConfiguration` ? Because the returned value is not "serialized".
##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/source/HBaseInputFormat.java
##########
@@ -36,6 +35,10 @@
private static final long serialVersionUID = 1L;
+ public HBaseInputFormat(org.apache.hadoop.conf.Configuration hConf) {
Review comment:
Could you add some Javadoc on this? What is the `hConf` and what values should be contained in the `hConf`?
##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/source/AbstractTableInputFormat.java
##########
@@ -99,6 +108,14 @@
*/
public abstract void configure(Configuration parameters);
+ protected void setSerializedConfig(org.apache.hadoop.conf.Configuration hConf) {
Review comment:
I think we don't need such method, we can directly call `HBaseConfigurationUtil.serializeConfiguration` in the construct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org