You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/02 02:15:47 UTC
[GitHub] [superset] jinghua-qa opened a new issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
jinghua-qa opened a new issue #16009:
URL: https://github.com/apache/superset/issues/16009
Unexpected error show when drop from 'Metric' in 'Percentage Metric'
### Expected results
No error show
### Actual results
Unexpected error show when drop from 'Metric' in 'Percentage Metric'
#### Screenshots
https://user-images.githubusercontent.com/81597121/127795512-1d5c1b6a-cfbf-47b4-ae22-5af20d339e21.mov
=
#### How to reproduce the bug
1. Open Table 'Breakdown of developer Type'
2. Drop COUNT(Developer_type) to Metrics from left column
3. Drop COUNT(First time developer) to Percentage Metrics from left column
4. Drop COUNT(Developer_type) from Metric to Percentage Metrics
5. see error
### Environment
(please complete the following information):
- superset version: `master`
- python version: `python --version`
- node.js version: `node -v`
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-890746976
@junlincc I saw 'Filter' can accept drop from other fields, is this expected? should i field bugs for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-890719097
@junlincc I bet that's the same problem as with dragging column from rows to columns control. Of course it's a bug, but I'm fairly sure that it used to work as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-890844102
> @junlincc I saw 'Filter' can accept drop from other fields, is this expected? should i field bugs for that?
Could you please show a recording/steps to reproduce? Filter works fine for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mistercrunch commented on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-890695764
Feels to me that `Unexpected errors` are bugs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-890715804
> Feels to me that `Unexpected errors` are bugs
For this stage, the expected behavior should be to highlight cross field dropping in Red. but we can certainly skip to make it support drop. @mistercrunch
@pkdotson wanna try this one? 😁
Should: when user drag a metric from one Metric related dropzone to another, highlight the designated drop area in RED, to indicate not support.
Nice to have: make cross field DnD works. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-890841471
@jinghua-qa in general the issue occurs when we have 2 controls of the same type. The fix is in progress
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-891016651
Fix: https://github.com/apache/superset/pull/16020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-890715804
> Feels to me that `Unexpected errors` are bugs
For this stage, the expected behavior should be to highlight cross field dropping in Red. but we can certainly skip to make it support drop. @mistercrunch
@pkdotson wanna try this one? 😁
Should: when user drag a metric from one Metric related dropzone to another, highlight the designated drop area in RED, to indicate not support.
Nice to have: make cross field DnD works. :)
Feel free to reach out to @kgabryje for context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-890840171
Saw same issue in example chart 'Parallel Coordinates' chart, when drag and drop "Metrics' to "color metrics'
https://user-images.githubusercontent.com/81597121/127830289-8239f789-af0c-45dd-bb54-7c4134f2f395.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
kgabryje closed issue #16009:
URL: https://github.com/apache/superset/issues/16009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-890715804
> Feels to me that `Unexpected errors` are bugs
For this stage, the expected behavior should be to highlight cross field dropping in Red. but we can certainly skip to make it support drop. @mistercrunch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16009: [d&d][Table]Unexpected error show when accept drop from 'Metric' in 'Percentage Metric'
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16009:
URL: https://github.com/apache/superset/issues/16009#issuecomment-890668597
this is a feature request, not a bug. but we should have better indication for non-supported cross field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org