You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/01 17:34:01 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3856: [ISSUE #3855]General code simplification
pandaapo opened a new pull request, #3856:
URL: https://github.com/apache/eventmesh/pull/3856
Fixes #3855.
### Motivation
see "Enhancement Request" in issue related.
### Modifications
see "Describe the solution you'd like" in issue related.
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3855] General code simplification (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #3856:
URL: https://github.com/apache/eventmesh/pull/3856#issuecomment-2071601267
I agree with "use it when you require frequent access to static members from one or two classes". The class name of a static import member is helpful to indicate the use of the member.
Please resolve conflicts~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 commented on pull request #3856: [ISSUE #3855]General code simplification
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #3856:
URL: https://github.com/apache/eventmesh/pull/3856#issuecomment-1547495402
> revoke a portion except for accessing 3 or more static members of a type
IMO, revoke a portion except for accessing 3 or more static members of a type is better. @pandaapo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3856: [ISSUE #3855]General code simplification
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3856:
URL: https://github.com/apache/eventmesh/pull/3856#issuecomment-1535835063
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3856](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (466a92b) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/91aab4d4ec18b7644c45e745fc85aafd053d8fd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91aab4d) will **decrease** coverage by `0.02%`.
> The diff coverage is `30.30%`.
> :exclamation: Current head 466a92b differs from pull request most recent head 21f0bb9. Consider uploading reports for the commit 21f0bb9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3856 +/- ##
============================================
- Coverage 13.77% 13.76% -0.02%
Complexity 1290 1290
============================================
Files 571 571
Lines 29129 29093 -36
Branches 2837 2836 -1
============================================
- Hits 4012 4004 -8
+ Misses 24745 24717 -28
Partials 372 372
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/eventmesh/common/ThreadPoolFactory.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9UaHJlYWRQb29sRmFjdG9yeS5qYXZh) | `16.66% <ø> (ø)` | |
| [...mmon/protocol/grpc/common/BatchMessageWrapper.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL2NvbW1vbi9CYXRjaE1lc3NhZ2VXcmFwcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...mon/protocol/grpc/common/SimpleMessageWrapper.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL2NvbW1vbi9TaW1wbGVNZXNzYWdlV3JhcHBlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...entmesh/common/protocol/http/HttpEventWrapper.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL0h0dHBFdmVudFdyYXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/eventmesh/common/protocol/tcp/Package.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC90Y3AvUGFja2FnZS5qYXZh) | `75.00% <60.00%> (+1.66%)` | :arrow_up: |
| [...he/eventmesh/common/protocol/http/HttpCommand.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL0h0dHBDb21tYW5kLmphdmE=) | `66.25% <84.21%> (+7.62%)` | :arrow_up: |
| [...pache/eventmesh/common/EventMeshThreadFactory.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9FdmVudE1lc2hUaHJlYWRGYWN0b3J5LmphdmE=) | `61.11% <100.00%> (-8.46%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3856: [ISSUE #3855]General code simplification
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3856:
URL: https://github.com/apache/eventmesh/pull/3856#issuecomment-1539686490
> @pandaapo please fix the conflicts.
OK.
But 2 questions:
1. What do you think about this [review](https://github.com/apache/eventmesh/pull/3856#issuecomment-1533635816)? Should I revoke all of `import static`? Or revoke a portion except for accessing a static member of a type 3 or more times? CC @mxsm
2. Today, I cannot receive any email, even GitHub notification about all review messages. Does GitHub or EventMesh repository settings or my settings(I do nothing) occur exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3856: [ISSUE #3855]General code simplification
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3856:
URL: https://github.com/apache/eventmesh/pull/3856#issuecomment-1539687253
> @pandaapo please fix the conflicts.
OK.
But 2 questions:
1. What do you think about this [review](https://github.com/apache/eventmesh/pull/3856#issuecomment-1533635816)? Should I revoke all of `import static`? Or revoke a portion except for accessing a static member of a type 3 or more times? CC @mxsm
2. Today, I cannot receive any email, even GitHub notification about all review messages. Does GitHub or EventMesh repository settings or my settings(I do nothing) occur exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 commented on pull request #3856: [ISSUE #3855]General code simplification
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #3856:
URL: https://github.com/apache/eventmesh/pull/3856#issuecomment-1539315455
@pandaapo please fix the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3855]General code simplification (eventmesh)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3856:
URL: https://github.com/apache/eventmesh/pull/3856#issuecomment-2070568903
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3856: [ISSUE #3855]General code simplification
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3856:
URL: https://github.com/apache/eventmesh/pull/3856#issuecomment-1533635816
> Hi @pandaapo IMO, If you overuse the static import feature, it makes the program unreadable and unmaintainable.
Thanks for your review. It is indeed controversial about `import static`'s advantage and disadvantage. I will revoke these modifications as an acceptance of community rules.
In addition, I think it will be better if community can specify when to use `import static` as part of code conduct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3855]General code simplification (eventmesh)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3856:
URL: https://github.com/apache/eventmesh/pull/3856#issuecomment-2070570040
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3856?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `30.30303%` with `46 lines` in your changes are missing coverage. Please review.
> Project coverage is 13.92%. Comparing base [(`3f49cd4`)](https://app.codecov.io/gh/apache/eventmesh/commit/3f49cd4b7aa0570f4c276f9ac49ef260bf8920c9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8abfaed`)](https://app.codecov.io/gh/apache/eventmesh/pull/3856?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 404 commits behind head on master.
> :exclamation: Current head 8abfaed differs from pull request most recent head e1ca83c. Consider uploading reports for the commit e1ca83c to get more accurate results
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/3856?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...entmesh/common/protocol/http/HttpEventWrapper.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Fprotocol%2Fhttp%2FHttpEventWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL0h0dHBFdmVudFdyYXBwZXIuamF2YQ==) | 0.00% | [39 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/eventmesh/common/protocol/http/HttpCommand.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Fprotocol%2Fhttp%2FHttpCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL0h0dHBDb21tYW5kLmphdmE=) | 84.21% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/eventmesh/common/protocol/tcp/Package.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Fprotocol%2Ftcp%2FPackage.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC90Y3AvUGFja2FnZS5qYXZh) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mmon/protocol/grpc/common/BatchMessageWrapper.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Fprotocol%2Fgrpc%2Fcommon%2FBatchMessageWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL2NvbW1vbi9CYXRjaE1lc3NhZ2VXcmFwcGVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mon/protocol/grpc/common/SimpleMessageWrapper.java](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Fprotocol%2Fgrpc%2Fcommon%2FSimpleMessageWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL2NvbW1vbi9TaW1wbGVNZXNzYWdlV3JhcHBlci5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3856 +/- ##
============================================
- Coverage 16.91% 13.92% -3.00%
+ Complexity 1410 1291 -119
============================================
Files 588 570 -18
Lines 25743 28806 +3063
Branches 2376 2806 +430
============================================
- Hits 4355 4011 -344
- Misses 20954 24422 +3468
+ Partials 434 373 -61
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/3856?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org