You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2016/11/11 13:51:24 UTC

[GitHub] thrift pull request #1127: THRIFT-3947 use sockaddr_storage with getsockname...

GitHub user jeking3 opened a pull request:

    https://github.com/apache/thrift/pull/1127

    THRIFT-3947 use sockaddr_storage with getsockname for future transport compatibility (ipv6)

    There's also code in windows/SocketPair that uses sockaddr_in however that code is using loopback so I see no need to change it.  The rest of the codebase already changed over to use sockaddr_storage at some point in the past.  Only this lua implementation was left...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeking3/thrift defect/THRIFT-3947

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1127
    
----
commit 544bd38fa3d396cab95bef6a65d36e444437e086
Author: James E. King, III <ji...@simplivity.com>
Date:   2016-11-11T04:29:56Z

    THRIFT-3947 use sockaddr_storage with getsockname for future transport compatibility (ipv6)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1127: THRIFT-3947 use sockaddr_storage with getsockname...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1127


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---