You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/19 19:05:33 UTC

[GitHub] [spark] MaxGekk opened a new pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

MaxGekk opened a new pull request #31247:
URL: https://github.com/apache/spark/pull/31247


   ### What changes were proposed in this pull request?
   While adding new partition to v2 `InMemoryAtomicPartitionTable`/`InMemoryPartitionTable`, add single row to the table content when the table is fully partitioned.
   
   ### Why are the changes needed?
   The `ALTER TABLE .. ADD PARTITION` command does not change content of fully partitioned v2 table. For instance, `INSERT INTO` changes table content:
   ```scala
         sql(s"CREATE TABLE t (p0 INT, p1 STRING) USING _ PARTITIONED BY (p0, p1)")
         sql(s"INSERT INTO t SELECT 1, 'def'")
         sql(s"SELECT * FROM t").show(false)
   
   +---+---+
   |p0 |p1 |
   +---+---+
   |1  |def|
   +---+---+
   ```
   but `ALTER TABLE .. ADD PARTITION` doesn't change v2 table content:
   ```scala
         sql(s"ALTER TABLE t ADD PARTITION (p0 = 0, p1 = 'abc')")
         sql(s"SELECT * FROM t").show(false)
   
   +---+---+
   |p0 |p1 |
   +---+---+
   +---+---+
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   No, the changes impact only on tests but for the example above in tests:
   ```scala
         sql(s"ALTER TABLE t ADD PARTITION (p0 = 0, p1 = 'abc')")
         sql(s"SELECT * FROM t").show(false)
   
   +---+---+
   |p0 |p1 |
   +---+---+
   |0  |abc|
   +---+---+
   ```
   
   ### How was this patch tested?
   By running new test:
   ```
   $ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *AlterTablePartitionV2SQLSuite"
   ```
   
   Authored-by: Max Gekk <ma...@gmail.com>
   Signed-off-by: Wenchen Fan <we...@databricks.com>
   (cherry picked from commit a98e77c1138c0f232ac99f151ef2ecbf332b6fbc)
   Signed-off-by: Max Gekk <ma...@gmail.com>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31247:
URL: https://github.com/apache/spark/pull/31247#issuecomment-763068314


   **[Test build #134236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134236/testReport)** for PR 31247 at commit [`ef59dc0`](https://github.com/apache/spark/commit/ef59dc080f2115ccd1c73b39388948ebc541d2d6).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31247:
URL: https://github.com/apache/spark/pull/31247#issuecomment-763137681


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38821/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31247:
URL: https://github.com/apache/spark/pull/31247#issuecomment-763090395


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38821/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31247:
URL: https://github.com/apache/spark/pull/31247


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31247:
URL: https://github.com/apache/spark/pull/31247#issuecomment-763068314


   **[Test build #134236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134236/testReport)** for PR 31247 at commit [`ef59dc0`](https://github.com/apache/spark/commit/ef59dc080f2115ccd1c73b39388948ebc541d2d6).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31247:
URL: https://github.com/apache/spark/pull/31247#issuecomment-763108304


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38821/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31247:
URL: https://github.com/apache/spark/pull/31247#issuecomment-763137681


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38821/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31247:
URL: https://github.com/apache/spark/pull/31247#issuecomment-763214705


   **[Test build #134236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134236/testReport)** for PR 31247 at commit [`ef59dc0`](https://github.com/apache/spark/commit/ef59dc080f2115ccd1c73b39388948ebc541d2d6).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31247:
URL: https://github.com/apache/spark/pull/31247#issuecomment-763225324


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134236/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31247:
URL: https://github.com/apache/spark/pull/31247#issuecomment-763225324


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134236/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #31247: [SPARK-34143][SQL][TESTS][3.1] Fix adding partitions to fully partitioned v2 tables

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31247:
URL: https://github.com/apache/spark/pull/31247#issuecomment-763254201


   Merged to branch-3.1.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org