[jira] [Commented] (SLING-10503) DefaultQueryExecutor should not log the full Schema Definition on error

["Bertrand Delacretaz (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367479#comment-17367479 ] 

Bertrand Delacretaz commented on SLING-10503:
---------------------------------------------

Thank you for this! I have incorporated your PR#24 changes in commit [d430d47|https://github.com/apache/sling-org-apache-sling-graphql-core/commit/d430d47df5b190107d413f31ef19052aacab4d98] (with credits) along with new tests that validate the log messages.

Please cross-check, and if ok you can mark this ticket resolved.

> DefaultQueryExecutor should not log the full Schema Definition on error
> -----------------------------------------------------------------------
>
>                 Key: SLING-10503
>                 URL: https://issues.apache.org/jira/browse/SLING-10503
>             Project: Sling
>          Issue Type: Improvement
>          Components: GraphQL
>    Affects Versions: GraphQL Core 0.0.10
>            Reporter: Denis Moret
>            Priority: Major
>
> If an exception is caught during a query execution, the full schema definition is logged. If the schema is large or if the error is repeating, it might induce a large quantity of logs.
> I would suggest to log the schema definition on DEBUG log level only.
> [https://github.com/apache/sling-org-apache-sling-graphql-core/blob/5d43e133d6c0d29feb7499e28cb9a3f617b5a8a4/src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java#L231]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)