[GitHub] [flink] wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests

[GitBox <gi...@apache.org>]

wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365635088
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
 ##########
 @@ -26,26 +26,56 @@ MINIKUBE_START_RETRIES=3
 MINIKUBE_START_BACKOFF=5
 RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
 
+# If running tests on non-linux os, the kubectl and minikube should be installed manually
+function setup_kubernetes_for_linux {
+    # Download kubectl, which is a requirement for using minikube.
+    if ! [ -x "$(command -v kubectl)" ]; then
+        local version=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+        curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/$version/bin/linux/amd64/kubectl && \
+            chmod +x kubectl && sudo mv kubectl /usr/local/bin/
 
 Review comment:
   Yeah, we have the `sudo: required` in `.travis.yml`. So we will have the sudo permission without providing password.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services