[GitHub] [arrow] nealrichardson commented on a diff in pull request #12980: ARROW-16281 [R] [CI] Bump versions with the release of 4.2

[GitBox <gi...@apache.org>]

nealrichardson commented on code in PR #12980:
URL: https://github.com/apache/arrow/pull/12980#discussion_r859828177


##########
dev/tasks/tasks.yml:
##########
@@ -1286,9 +1286,9 @@ tasks:
 
 {% for r_org, r_image, r_tag in [("rhub", "ubuntu-gcc-release", "latest"),
                                  ("rocker", "r-base", "latest"),
-                                 ("rstudio", "r-base", "4.1-focal"),
-                                 ("rstudio", "r-base", "4.1-opensuse15"),
-                                 ("rstudio", "r-base", "4.1-opensuse42")] %}
+                                 ("rstudio", "r-base", "4.2-focal"),

Review Comment:
   Do these images exist already?



##########
.github/workflows/r.yml:
##########
@@ -177,6 +177,9 @@ jobs:
         - { rtools: 40, arch: 'mingw32' }
         - { rtools: 40, arch: 'mingw64' }
         - { rtools: 40, arch: 'ucrt64' }
+        - { rtools: 42, arch: 'mingw32' }
+        - { rtools: 42, arch: 'mingw64' }
+        - { rtools: 42, arch: 'ucrt64' }

Review Comment:
   I don't think you need these. The C++ libraries built with rtools40 will work with R with rtools42.



##########
dev/tasks/r/github.linux.versions.yml:
##########
@@ -31,9 +31,9 @@ jobs:
           # We test devel, release, and oldrel in regular CI.
           # This is for older versions
           # glue depends on R >= 3.4, and vctrs depends on glue
-          - "3.4"
           - "3.5"
           - "3.6"
+          - "4.0"

Review Comment:
   Should this also have 4.1?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org