You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/04/26 14:02:30 UTC

[GitHub] incubator-zeppelin pull request: add /r/lib/ in .gitignore

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/857

    add /r/lib/ in .gitignore

    ### What is this PR for?
    after compiling/building Zeppelin project with default/R `mvn $BUILD_FLAG $PROFILE -B`, this directory `/r/lib/` gets created.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - add /r/lib/ in .gitignore
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    Compile/build Zeppelin project with R/default options `mvn $BUILD_FLAG $PROFILE -B`, then do a git status. This directory `/r/lib/` should not show up.
    
    ### Screenshots (if appropriate)
    N/A
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/incubator-zeppelin gitignoreR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/857.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #857
    
----
commit 4d45248f1211941d35effe928cb93b259137639d
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2016-04-26T11:42:14Z

    add /r/lib/ in .gitignore

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: add /r/lib/ in .gitignore

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/857#issuecomment-214847334
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: add /r/lib/ in .gitignore

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/857#issuecomment-215134558
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: add /r/lib/ in .gitignore

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/857


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: add /r/lib/ in .gitignore

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/857#issuecomment-215134208
  
    Merging if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---