You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/24 05:24:35 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #1289: rewind: clear the error indicator
yamt opened a new pull request #1289:
URL: https://github.com/apache/incubator-nuttx/pull/1289
## Summary
Make rewind() clear the error indicator of the stream
as it's specified by the standards.
## Impact
apps relying on the old (wrong) behavior will break. it's quite unlikely though.
## Testing
tested with my local app.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1289: rewind: clear the error indicator
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1289:
URL: https://github.com/apache/incubator-nuttx/pull/1289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1289: rewind: clear the error indicator
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #1289:
URL: https://github.com/apache/incubator-nuttx/pull/1289#discussion_r444665430
##########
File path: libs/libc/stdio/lib_rewind.c
##########
@@ -0,0 +1,45 @@
+/****************************************************************************
+ * libs/libc/stdio/lib_rewind.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdio.h>
+
+#include "libc.h"
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: rewind
+ ****************************************************************************/
+
+void rewind(FAR FILE *stream)
+{
+ lib_take_semaphore(stream);
Review comment:
thank you. i'm not a big fan of sprinkling NULL checks everywhere. but i added it for consistency for other functions around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1289: rewind: clear the error indicator
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1289:
URL: https://github.com/apache/incubator-nuttx/pull/1289#discussion_r444662108
##########
File path: libs/libc/stdio/lib_rewind.c
##########
@@ -0,0 +1,45 @@
+/****************************************************************************
+ * libs/libc/stdio/lib_rewind.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdio.h>
+
+#include "libc.h"
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: rewind
+ ****************************************************************************/
+
+void rewind(FAR FILE *stream)
+{
+ lib_take_semaphore(stream);
Review comment:
should we check stream != NULL before holding sempahore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org