You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/08/03 13:51:31 UTC

[GitHub] [phoenix-omid] stoty commented on a change in pull request #62: OMID-156 refactor Omid to use phoenix-shaded-guava

stoty commented on a change in pull request #62:
URL: https://github.com/apache/phoenix-omid/pull/62#discussion_r464426603



##########
File path: common/src/main/java/org/apache/omid/NetworkUtils.java
##########
@@ -34,6 +36,14 @@
 
     public static String getDefaultNetworkInterface() {
 
+        try (DatagramSocket s=new DatagramSocket()) {

Review comment:
       This code in particular is meant to change behaviour.
   It is actually part of OMID-157, to get the Travis test running, but the fix should apply to a lot of (virtualised) environments.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org