[jira] [Commented] (SOLR-15057) avoid unnecessary object retention in FacetRangeProcessor

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260728#comment-17260728 ] 

ASF subversion and git services commented on SOLR-15057:
--------------------------------------------------------

Commit 60f2417acad5157fad5fe78ef9404f2bb979d7ec in lucene-solr's branch refs/heads/master from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=60f2417 ]

SOLR-15057: avoid unnecessary object retention in FacetRangeProcessor (#2160)



> avoid unnecessary object retention in FacetRangeProcessor
> ---------------------------------------------------------
>
>                 Key: SOLR-15057
>                 URL: https://issues.apache.org/jira/browse/SOLR-15057
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
>  * The (private) {{doSubs}} method is a no-op if there are no sub-facets.
>  * The (private) {{intersections}} and {{filters}} arrays are only used by the {{doSubs}} method.
>  * The (private) {{rangeStats}} method currently always populates the {{intersections}} and {{filters}} arrays, even when nothing actually subsequently uses them.
>  * If {{rangeStats}} only populated the {{intersections}} array when it's actually needed then the {{DocSet intersection}} object would remain local in scope and hence the garbage collector could collect it earlier.
> [https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.7.0/solr/core/src/java/org/apache/solr/search/facet/FacetRangeProcessor.java#L531-L555]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org