You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "milenkovicm (via GitHub)" <gi...@apache.org> on 2025/01/21 21:20:22 UTC

[PR] fix: do not compile `keda.proto` if feature not used. [datafusion-ballista]

milenkovicm opened a new pull request, #1168:
URL: https://github.com/apache/datafusion-ballista/pull/1168

   # Which issue does this PR close?
   
   Closes None.
   
    # Rationale for this change
   
   Scheduler compiles `keda.proto` even if it's disabled, compilation requires `protoc` installed affecting user experience.
   
   # What changes are included in this PR?
   
   with this patch `protoc` will be required only if `keda-scaler` feature is enabled.
   
   # Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] fix: do not compile `keda.proto` if feature not used. [datafusion-ballista]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #1168:
URL: https://github.com/apache/datafusion-ballista/pull/1168


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org