You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/28 14:58:02 UTC
[GitHub] [airflow] mdering opened a new pull request, #27961: add some missing options for the gcs to bq operator
mdering opened a new pull request, #27961:
URL: https://github.com/apache/airflow/pull/27961
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes #27842
---
Add in some missing configuration options to the gcs to bq transfer operator. the 8.5.0 release broke a number of things with this operator, mainly the methods to specify the file delimiter, and the time partitioning option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #27961: add some missing options for the gcs to bq operator
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #27961:
URL: https://github.com/apache/airflow/pull/27961#issuecomment-1332344788
> Is there something you need from me to rerun this?
Can you please add unit test to avoid regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mdering commented on pull request #27961: add some missing options for the gcs to bq operator
Posted by GitBox <gi...@apache.org>.
mdering commented on PR #27961:
URL: https://github.com/apache/airflow/pull/27961#issuecomment-1332488625
@eladkal yes, I added some tests, and fixed the existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mdering commented on pull request #27961: Fix: re-enable use of parameters in gcs_to_bq which had been disabled
Posted by GitBox <gi...@apache.org>.
mdering commented on PR #27961:
URL: https://github.com/apache/airflow/pull/27961#issuecomment-1333843465
since this passed CI and has unit tests, is there anything else I need to do to get this merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #27961: Fix: re-enable use of parameters in gcs_to_bq which had been disabled
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27961:
URL: https://github.com/apache/airflow/pull/27961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #27961: add some missing options for the gcs to bq operator
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #27961:
URL: https://github.com/apache/airflow/pull/27961#issuecomment-1329973707
CI is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #27961: Fix: re-enable use of parameters in gcs_to_bq which had been disabled
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #27961:
URL: https://github.com/apache/airflow/pull/27961#issuecomment-1336492180
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mdering commented on pull request #27961: add some missing options for the gcs to bq operator
Posted by GitBox <gi...@apache.org>.
mdering commented on PR #27961:
URL: https://github.com/apache/airflow/pull/27961#issuecomment-1332301061
Is there something you need from me to rerun this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #27961: add some missing options for the gcs to bq operator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #27961:
URL: https://github.com/apache/airflow/pull/27961#issuecomment-1329249276
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mdering commented on pull request #27961: add some missing options for the gcs to bq operator
Posted by GitBox <gi...@apache.org>.
mdering commented on PR #27961:
URL: https://github.com/apache/airflow/pull/27961#issuecomment-1331012831
@uranusjr I see why, can you approve it to rerun tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org