[jira] [Comment Edited] (CALCITE-1337) Lazy evaluate RexCall digests

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435191#comment-15435191 ] 

Julian Hyde edited comment on CALCITE-1337 at 8/24/16 4:16 PM:
---------------------------------------------------------------

Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/aea8a686. Thanks for the PR, [~tedxu]!

Although ropes are discussed above, this fix does not include ropes. As of this fix, the digest of a call contains, by copying the characters of the constituent strings, the digests of the arguments. It is computed the first time that someone calls {{RexCall#toString}}.


was (Author: julianhyde):
Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/aea8a686. Thanks for the PR, [~tedxu]!

> Lazy evaluate RexCall digests
> -----------------------------
>
>                 Key: CALCITE-1337
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1337
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Ted Xu
>            Assignee: Julian Hyde
>             Fix For: 1.9.0
>
>         Attachments: p.patch
>
>
> Currently RexCall compute digests eagerly in its constructor, also, it compute digest every time when toString invoked. It may cause performance issue when the RexCall tree is very large.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)