You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/10/08 18:15:05 UTC

[GitHub] [accumulo] keith-turner commented on pull request #1670: #1631 - Tablet in memory compaction ID is updated before metadata write

keith-turner commented on pull request #1670:
URL: https://github.com/apache/accumulo/pull/1670#issuecomment-705739580


   @cradal  and @ctubbsii  the current changes look good.  To close out #1631  I think one more change is needed.  At the following line there is also a call to update the compaction Id in memory.  
   
   https://github.com/apache/accumulo/blob/80ee9ca8092dc4bf07aa1a046d6e668f0e16300e/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L449
   
   A few lines later  `MasterMetadataUtil.replaceDatafiles()` is called which updates the compaction id in the metadata table.  Should probably update memory after the metadata update.
   
   https://github.com/apache/accumulo/blob/80ee9ca8092dc4bf07aa1a046d6e668f0e16300e/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L457


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org