You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smitajoshi12 (via GitHub)" <gi...@apache.org> on 2023/08/29 09:45:46 UTC
[GitHub] [ozone] smitajoshi12 opened a new pull request, #5232: Recon HeatMap UI issues
smitajoshi12 opened a new pull request, #5232:
URL: https://github.com/apache/ozone/pull/5232
## What changes were proposed in this pull request?
Few HeatMap issues:
1) Not able to enter "/s3v/cloudera-health-monitoring-ozone-basic-canary-bucket/cloudera-health-monitoring-ozone-basic-canary-key" in path box.
2) Tooltip always show FileName label irrespective of entity type selected. It should display label as Key Name, if selected bucket entity type, tool tip should have label Bucket Name and if volume, the should be Volume Name.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9224
## How was this patch tested?
Manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] devmadhuu commented on pull request #5232: HDDS-9224. Recon HeatMap UI issues
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #5232:
URL: https://github.com/apache/ozone/pull/5232#issuecomment-1715669356
> @smitajoshi12 I can't ignore data, as I don't have too much else to test the functionality of your change. Also if you attach this as testing, it should show correct data. I'm still not sure if the implementation is correct.
>
> I think the most outstanding thing is that on the last screenshot the tooltip is coming from the bucket, which has the name `HIVEBUCKETTEST2` based on the heatmap figure. This tooltip shows `Volume Name:` and after that the bucket name is showing up. This is definitely wrong. Either it should show the volume name (which is the "parent") or it should be a "Bucket Name". This can be figured out even if the names are "incorrect" to their type. Can you look into this a bit more? Thanks!
>
> Also I don't think that the `childEntityType` in the code is the correct name, as we are talking about the parents of the entites (eg. for a bucket, it has a "parent" volume; it can have more child entities, so it wouldn't make sense to show that).
>
> I wanted to try this out in a docker cluster locally with my data, but I'm not sure how can I enable heatmap, I don't see it there default? Can you help me with this @devmadhuu? Thanks!
@smitajoshi12 , you can show screenshots with your db.json data in each case (volume, bucket, key, file)...
@dombizita , in upstream this will not be enabled , so cannot test with live data in upstream, however yes, you can create an internal cluster to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita merged pull request #5232: HDDS-9224. Recon HeatMap UI issues
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita merged PR #5232:
URL: https://github.com/apache/ozone/pull/5232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on pull request #5232: HDDS-9224. Recon HeatMap UI issues
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5232:
URL: https://github.com/apache/ozone/pull/5232#issuecomment-1719021090
could take a look at the latest patch @devmadhuu, @devabhishekpal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on pull request #5232: HDDS-9224. Recon HeatMap UI issues
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on PR #5232:
URL: https://github.com/apache/ozone/pull/5232#issuecomment-1715505913
> I'm no too familiar with this, but based on the screenshots for the keys you are showing `Key Name`, which seems correct for me. on the 2nd screenshot, when the cursor is on a bucket, the bucket's name is `test11.dat`? or is it showing a wrong name? also `hivebucketTest2` is a volume? what would happen if the cursor is on the `HIVEVOLTEST2` and what is that? can you attach a basic example of `vol1`, `bucket1` and `key1`? or just add the names and types of the entities in a comment?
@Zita
Earlier in tooltip FileName label was static for key volume and bucket so as per suggestion we changed to dynamic if it is Key we are replacing Key Name, if it is volume we are changing to Volume Name if it is bucket we are chnaging to Bucket Name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on pull request #5232: HDDS-9224. Recon HeatMap UI issues
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on PR #5232:
URL: https://github.com/apache/ozone/pull/5232#issuecomment-1715550881
> m not sure that the current implementation is correct. To
> > > I'm no too familiar with this, but based on the screenshots for the keys you are showing `Key Name`, which seems correct for me. on the 2nd screenshot, when the cursor is on a bucket, the bucket's name is `test11.dat`? or is it showing a wrong name? also `hivebucketTest2` is a volume? what would happen if the cursor is on the `HIVEVOLTEST2` and what is that? can you attach a basic example of `vol1`, `bucket1` and `key1`? or just add the names and types of the entities in a comment?
> >
> >
> > @zita Earlier in tooltip FileName label was static for key volume and bucket so as per suggestion we changed to dynamic if it is Key we are replacing Key Name, if it is volume we are changing to Volume Name if it is bucket we are chnaging to Bucket Name.
>
> I understand the changes, but I'm not sure that the current implementation is correct. To make it sure, I'd like to know the types of the entities that we are seeing in the screenshots. Currently the volume/bucket/key names seems to be not so straightforward, e.g. (these are copied from the screenshot):
>
> * `Volume Name: hivebucketTest2` (it contains the _bucket_ word)
> * `Bucket Name: test11.dat` (this seems to be a file, based on the extension)
>
> I have a detailed list of the names/types in my previous comment. Could you upload screenshots with simple `vol1`, `bucket1` and `key1` names?
Can you ignore data as is mockdata for local check. I have to change Bucket and Volume and Keys DB.json ata as per cluster.data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on pull request #5232: HDDS-9224. Recon HeatMap UI issues
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5232:
URL: https://github.com/apache/ozone/pull/5232#issuecomment-1715540340
> > I'm no too familiar with this, but based on the screenshots for the keys you are showing `Key Name`, which seems correct for me. on the 2nd screenshot, when the cursor is on a bucket, the bucket's name is `test11.dat`? or is it showing a wrong name? also `hivebucketTest2` is a volume? what would happen if the cursor is on the `HIVEVOLTEST2` and what is that? can you attach a basic example of `vol1`, `bucket1` and `key1`? or just add the names and types of the entities in a comment?
>
> @zita Earlier in tooltip FileName label was static for key volume and bucket so as per suggestion we changed to dynamic if it is Key we are replacing Key Name, if it is volume we are changing to Volume Name if it is bucket we are chnaging to Bucket Name.
I understand the changes, but I'm not sure that the current implementation is correct. To make it sure, I'd like to know the types of the entities that we are seeing in the screenshots. Currently the volume/bucket/key names seems to be not so straightforward, e.g.:
- Volume Name: hivebucketTest2 (it contains the _bucket_ word)
- Bucket Name: test11.dat (this seems to be a file, based on the extension)
I have a detailed list of the names/types in my previous comment.
Could you upload screenshots with simple `vol1`, `bucket1` and `key1` names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on pull request #5232: HDDS-9224. Recon HeatMap UI issues
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5232:
URL: https://github.com/apache/ozone/pull/5232#issuecomment-1721311299
thanks for the patch @smitajoshi12! thanks for the review @devabhishekpal!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on pull request #5232: HDDS-9224. Recon HeatMap UI issues
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5232:
URL: https://github.com/apache/ozone/pull/5232#issuecomment-1715586758
@smitajoshi12 I can't ignore data, as I don't have too much else to test the functionality of your change. Also if you attach this as testing, it should show correct data. I'm still not sure if the implementation is correct.
I think the most outstanding thing is that on the last screenshot the tooltip is coming from the bucket, which has the name `HIVEBUCKETTEST2` based on the heatmap figure. This tooltip shows `Volume Name:` and after that the bucket name is showing up. This is definitely wrong. Either it should show the volume name (which is the "parent") or it should be a "Bucket Name". This can be figured out even if the names are "incorrect" to their type.
Also I don't think that the `childEntityType` in the code is the correct name, as we are talking about the parents of the entites (eg. for a bucket, it has a "parent" volume; it can have more child entities, so it wouldn't make sense to show that).
I wanted to try this out in a docker cluster locally with my data, but I'm not sure how can I enable heatmap, I don't see it there default? Can you help me with this? @devmadhuu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smitajoshi12 commented on pull request #5232: HDDS-9224. Recon HeatMap UI issues
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on PR #5232:
URL: https://github.com/apache/ozone/pull/5232#issuecomment-1716055122
> **Yes it will need backend Changes also as not able to differentiate between Volume,Bucket, Directories, Sub Directories and keys byseeing name only. Currently did changes as Entity Name so it will be consistent across all levels**.
@devmadhuu
I am reverting back changes as it is not applied to all levels not able to differentiate between Volume, Bucket, Keys and Directories just hovering on Cluster. Need more time for analysis on this bug or can create seprate Jira for it as it is discussed with Zita also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org