[GitHub] [airflow] potiuk commented on a change in pull request #19505: XCom.serialize_value should have all params set does

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #19505:
URL: https://github.com/apache/airflow/pull/19505#discussion_r757127766



##########
File path: airflow/models/xcom.py
##########
@@ -364,6 +372,12 @@ def orm_deserialize_value(self) -> Any:
         return BaseXCom.deserialize_value(self)
 
 
+def serialize_value_shim(**kwargs):
+    signature = inspect_function_arguments(XCom.serialize_value)
+    kwargs = {k: v for k, v in kwargs.items() if k in signature.bound_arguments}
+    return XCom.serialize_value(**kwargs)

Review comment:
       Very much agree with that - additionally, it's good to add more explanation in the commit message - so that it could be find in the history as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org