[GitHub] [arrow] zeroshade commented on a diff in pull request #34558: GH-34572: [Go][CSV] Add binary support for CSV

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #34558:
URL: https://github.com/apache/arrow/pull/34558#discussion_r1139258497


##########
go/arrow/csv/common.go:
##########
@@ -223,6 +223,7 @@ func validate(schema *arrow.Schema) {
 		case *arrow.Date32Type, *arrow.Date64Type:
 		case *arrow.Decimal128Type, *arrow.Decimal256Type:
 		case *arrow.ListType:
+		case arrow.BinaryDataType:

Review Comment:
   if you're not going to support the `LargeString` and `LargeBinary` types, then this should be just `*arrow.BinaryType` instead of `arrow.BinaryDataType` which is an interface that includes the Large variants



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org