You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fury.apache.org by "nandakumar131 (via GitHub)" <gi...@apache.org> on 2023/12/29 14:49:24 UTC
[PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
nandakumar131 opened a new pull request, #1285:
URL: https://github.com/apache/incubator-fury/pull/1285
#1274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on code in PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285#discussion_r1438805226
##########
NOTICE:
##########
@@ -3,3 +3,100 @@ Copyright 2023 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+================================================================
+
+This product includes a number of Dependencies with separate copyright notices
+and license terms. Your use of these submodules is subject to the terms and
+conditions of the following licenses.
+
+================================================================
+
+================================================================
+Apache-2.0 licenses
+================================================================
+The following components are provided under the Apache-2.0 License. See project link for details.
+The text of each license is the standard Apache 2.0 license.
+
+* guava (https://github.com/google/guava)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/util/Preconditions.java
+
+* spark (https://github.com/apache/spark)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/codegen/Code.java
+ java/fury-core/src/main/java/org/apache/fury/util/Platform.java
+ java/fury-format/src/main/java/org/apache/fury/format/vectorized/ArrowWriter.java
+
+* commons-io (https://github.com/apache/commons-io)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/io/ClassLoaderObjectInputStream.java
+
+
+* fast-serialization (https://github.com/RuedigerMoeller/fast-serialization)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/Identity2IdMap.java
+
+* ray (https://github.com/ray-project/ray)
+ Files:
+ ci/format.sh
+
+
+================================================================
+BSD-3-Clause licenses
+================================================================
+The following components are provided under the BSD-3-Clause License. See project link for details.
+The text of each license is also included in licenses/LICENSE-[project].txt.
+
+* kryo (https://github.com/EsotericSoftware/kryo)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Data.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Image.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Media.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/MediaContent.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Sample.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/BufferType.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/KryoState.java
+ java/fury-core/src/main/java/org/apache/fury/collection/FuryObjectMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/LongMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/ObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
Review Comment:
Moved `MemoryBuffer` under the Apache license.
Thanks for the info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285#issuecomment-1872197123
Seems like a good start to me. I suspect we might need tidy up and possibly some more additions but this could probably be merged as is to get us started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285#discussion_r1438783558
##########
NOTICE:
##########
@@ -3,3 +3,100 @@ Copyright 2023 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+================================================================
+
+This product includes a number of Dependencies with separate copyright notices
+and license terms. Your use of these submodules is subject to the terms and
+conditions of the following licenses.
+
+================================================================
+
+================================================================
+Apache-2.0 licenses
+================================================================
+The following components are provided under the Apache-2.0 License. See project link for details.
+The text of each license is the standard Apache 2.0 license.
+
+* guava (https://github.com/google/guava)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/util/Preconditions.java
+
+* spark (https://github.com/apache/spark)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/codegen/Code.java
+ java/fury-core/src/main/java/org/apache/fury/util/Platform.java
+ java/fury-format/src/main/java/org/apache/fury/format/vectorized/ArrowWriter.java
+
+* commons-io (https://github.com/apache/commons-io)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/io/ClassLoaderObjectInputStream.java
+
+
+* fast-serialization (https://github.com/RuedigerMoeller/fast-serialization)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/Identity2IdMap.java
+
+* ray (https://github.com/ray-project/ray)
+ Files:
+ ci/format.sh
+
+
+================================================================
+BSD-3-Clause licenses
+================================================================
+The following components are provided under the BSD-3-Clause License. See project link for details.
+The text of each license is also included in licenses/LICENSE-[project].txt.
+
+* kryo (https://github.com/EsotericSoftware/kryo)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Data.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Image.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Media.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/MediaContent.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Sample.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/BufferType.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/KryoState.java
+ java/fury-core/src/main/java/org/apache/fury/collection/FuryObjectMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/LongMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/ObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
Review Comment:
It is hard to maintain the list to me. Could we just use wildcard matcher? e.g. `fury-benchmark/*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285#discussion_r1438807957
##########
NOTICE:
##########
@@ -3,3 +3,100 @@ Copyright 2023 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+================================================================
+
+This product includes a number of Dependencies with separate copyright notices
+and license terms. Your use of these submodules is subject to the terms and
+conditions of the following licenses.
+
+================================================================
+
+================================================================
+Apache-2.0 licenses
+================================================================
+The following components are provided under the Apache-2.0 License. See project link for details.
+The text of each license is the standard Apache 2.0 license.
+
+* guava (https://github.com/google/guava)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/util/Preconditions.java
+
+* spark (https://github.com/apache/spark)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/codegen/Code.java
+ java/fury-core/src/main/java/org/apache/fury/util/Platform.java
+ java/fury-format/src/main/java/org/apache/fury/format/vectorized/ArrowWriter.java
+
+* commons-io (https://github.com/apache/commons-io)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/io/ClassLoaderObjectInputStream.java
+
+
+* fast-serialization (https://github.com/RuedigerMoeller/fast-serialization)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/Identity2IdMap.java
+
+* ray (https://github.com/ray-project/ray)
+ Files:
+ ci/format.sh
+
+
+================================================================
+BSD-3-Clause licenses
+================================================================
+The following components are provided under the BSD-3-Clause License. See project link for details.
+The text of each license is also included in licenses/LICENSE-[project].txt.
+
+* kryo (https://github.com/EsotericSoftware/kryo)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Data.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Image.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Media.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/MediaContent.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Sample.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/BufferType.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/KryoState.java
+ java/fury-core/src/main/java/org/apache/fury/collection/FuryObjectMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/LongMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/ObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
Review Comment:
@PragmaTwice I suggest maintaining exact file list, not all of those files comes from kryo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285#discussion_r1440003278
##########
licenses/LICENSE-node.txt:
##########
Review Comment:
@nandakumar131 can you elaborate how this file generated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285#discussion_r1438809215
##########
NOTICE:
##########
@@ -3,3 +3,100 @@ Copyright 2023 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+================================================================
+
+This product includes a number of Dependencies with separate copyright notices
+and license terms. Your use of these submodules is subject to the terms and
+conditions of the following licenses.
+
+================================================================
+
+================================================================
+Apache-2.0 licenses
+================================================================
+The following components are provided under the Apache-2.0 License. See project link for details.
+The text of each license is the standard Apache 2.0 license.
+
+* guava (https://github.com/google/guava)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/util/Preconditions.java
+
+* spark (https://github.com/apache/spark)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/codegen/Code.java
+ java/fury-core/src/main/java/org/apache/fury/util/Platform.java
+ java/fury-format/src/main/java/org/apache/fury/format/vectorized/ArrowWriter.java
+
+* commons-io (https://github.com/apache/commons-io)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/io/ClassLoaderObjectInputStream.java
+
+
+* fast-serialization (https://github.com/RuedigerMoeller/fast-serialization)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/Identity2IdMap.java
+
+* ray (https://github.com/ray-project/ray)
+ Files:
+ ci/format.sh
+
+
+================================================================
+BSD-3-Clause licenses
+================================================================
+The following components are provided under the BSD-3-Clause License. See project link for details.
+The text of each license is also included in licenses/LICENSE-[project].txt.
+
+* kryo (https://github.com/EsotericSoftware/kryo)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Data.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Image.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Media.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/MediaContent.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Sample.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/BufferType.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/KryoState.java
+ java/fury-core/src/main/java/org/apache/fury/collection/FuryObjectMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/LongMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/ObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
Review Comment:
Sounds good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang merged PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on code in PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285#discussion_r1438805041
##########
NOTICE:
##########
@@ -3,3 +3,100 @@ Copyright 2023 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+================================================================
+
+This product includes a number of Dependencies with separate copyright notices
+and license terms. Your use of these submodules is subject to the terms and
+conditions of the following licenses.
+
+================================================================
+
+================================================================
+Apache-2.0 licenses
+================================================================
+The following components are provided under the Apache-2.0 License. See project link for details.
+The text of each license is the standard Apache 2.0 license.
+
+* guava (https://github.com/google/guava)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/util/Preconditions.java
+
+* spark (https://github.com/apache/spark)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/codegen/Code.java
+ java/fury-core/src/main/java/org/apache/fury/util/Platform.java
+ java/fury-format/src/main/java/org/apache/fury/format/vectorized/ArrowWriter.java
+
+* commons-io (https://github.com/apache/commons-io)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/io/ClassLoaderObjectInputStream.java
+
+
+* fast-serialization (https://github.com/RuedigerMoeller/fast-serialization)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/Identity2IdMap.java
+
+* ray (https://github.com/ray-project/ray)
+ Files:
+ ci/format.sh
+
+
+================================================================
+BSD-3-Clause licenses
+================================================================
+The following components are provided under the BSD-3-Clause License. See project link for details.
+The text of each license is also included in licenses/LICENSE-[project].txt.
+
+* kryo (https://github.com/EsotericSoftware/kryo)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Data.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Image.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Media.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/MediaContent.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Sample.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/BufferType.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/KryoState.java
+ java/fury-core/src/main/java/org/apache/fury/collection/FuryObjectMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/LongMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/ObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285#discussion_r1438500441
##########
NOTICE:
##########
@@ -3,3 +3,100 @@ Copyright 2023 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+================================================================
+
+This product includes a number of Dependencies with separate copyright notices
+and license terms. Your use of these submodules is subject to the terms and
+conditions of the following licenses.
+
+================================================================
+
+================================================================
+Apache-2.0 licenses
+================================================================
+The following components are provided under the Apache-2.0 License. See project link for details.
+The text of each license is the standard Apache 2.0 license.
+
+* guava (https://github.com/google/guava)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/util/Preconditions.java
+
+* spark (https://github.com/apache/spark)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/codegen/Code.java
+ java/fury-core/src/main/java/org/apache/fury/util/Platform.java
+ java/fury-format/src/main/java/org/apache/fury/format/vectorized/ArrowWriter.java
+
+* commons-io (https://github.com/apache/commons-io)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/io/ClassLoaderObjectInputStream.java
+
+
+* fast-serialization (https://github.com/RuedigerMoeller/fast-serialization)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/Identity2IdMap.java
+
+* ray (https://github.com/ray-project/ray)
+ Files:
+ ci/format.sh
+
+
+================================================================
+BSD-3-Clause licenses
+================================================================
+The following components are provided under the BSD-3-Clause License. See project link for details.
+The text of each license is also included in licenses/LICENSE-[project].txt.
+
+* kryo (https://github.com/EsotericSoftware/kryo)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Data.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Image.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Media.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/MediaContent.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Sample.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/BufferType.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/KryoState.java
+ java/fury-core/src/main/java/org/apache/fury/collection/FuryObjectMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/LongMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/ObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
Review Comment:
This is derived from apache flink, could we put it into apache license part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on code in PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285#discussion_r1440277111
##########
licenses/LICENSE-node.txt:
##########
Review Comment:
This is a copy of the LICENSE from [nodejs/node](https://github.com/nodejs/node).
https://github.com/nodejs/node/blob/main/LICENSE
This is mentioned in the NOTICE file
> The following components are provided under the Node.js License. See project link for details.
The text of each license is also included in licenses/LICENSE-[project].txt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] Update NOTICE to mention all the licenses for source files where code is borrowed from different project. [incubator-fury]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on code in PR #1285:
URL: https://github.com/apache/incubator-fury/pull/1285#discussion_r1438808736
##########
NOTICE:
##########
@@ -3,3 +3,100 @@ Copyright 2023 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+================================================================
+
+This product includes a number of Dependencies with separate copyright notices
+and license terms. Your use of these submodules is subject to the terms and
+conditions of the following licenses.
+
+================================================================
+
+================================================================
+Apache-2.0 licenses
+================================================================
+The following components are provided under the Apache-2.0 License. See project link for details.
+The text of each license is the standard Apache 2.0 license.
+
+* guava (https://github.com/google/guava)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/util/Preconditions.java
+
+* spark (https://github.com/apache/spark)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/codegen/Code.java
+ java/fury-core/src/main/java/org/apache/fury/util/Platform.java
+ java/fury-format/src/main/java/org/apache/fury/format/vectorized/ArrowWriter.java
+
+* commons-io (https://github.com/apache/commons-io)
+ Files:
+ java/fury-core/src/main/java/org/apache/fury/io/ClassLoaderObjectInputStream.java
+
+
+* fast-serialization (https://github.com/RuedigerMoeller/fast-serialization)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/Identity2IdMap.java
+
+* ray (https://github.com/ray-project/ray)
+ Files:
+ ci/format.sh
+
+
+================================================================
+BSD-3-Clause licenses
+================================================================
+The following components are provided under the BSD-3-Clause License. See project link for details.
+The text of each license is also included in licenses/LICENSE-[project].txt.
+
+* kryo (https://github.com/EsotericSoftware/kryo)
+ Files:
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Data.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Image.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Media.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/MediaContent.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/data/Sample.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/BufferType.java
+ java/fury-benchmark/src/main/java/org/apache/fury/benchmark/state/KryoState.java
+ java/fury-core/src/main/java/org/apache/fury/collection/FuryObjectMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/IdentityObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/LongMap.java
+ java/fury-core/src/main/java/org/apache/fury/collection/ObjectIntMap.java
+ java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java
Review Comment:
For now, I will add the exact file names. In the future, if we feel it's getting hard to maintain, we can replace it with wildcard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org