[GitHub] [flink] zhuzhurk commented on pull request #14462: [FLINK-20439][runtime] Rework `scheduleOrUpdateConsumers` to `notifyPartitionDataAvailable`

[GitBox <gi...@apache.org>]

zhuzhurk commented on pull request #14462:
URL: https://github.com/apache/flink/pull/14462#issuecomment-750006980


   Thanks for the reviewing @tillrohrmann 
   Sorry I just realized I made a mistake because updating an unknown input channel is still needed if BLOCKING edges exist in a pipelined region. 
   
   e.g.
   A --pipelined-->B, A --pipelined-->C, B --pipelined-->D, C --blocking-->D.
   
   In this case, even though D knows the location of C when deployed, the corresponding input channel will be unknown because C has not finished producing the BLOCKING result partition. This is needed because reading from an uncompleted BLOCKING result partition is not supported yet.
   
   So I reverted the changes which removed `scheduleOrUpdateConsumers()` in Execution and renamed it to `updatePartitionConsumers` to be aligned with its current responsibility. I also added a test `UpdatePartitionConsumersTest` to cover this case.
   
   This also means that FLINK-20721 is invalid so I will close it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org