You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by jp...@apache.org on 2014/07/23 19:29:43 UTC

svn commit: r1612882 - in /lucene/dev/branches/branch_4x: ./ lucene/ lucene/core/ lucene/core/src/java/org/apache/lucene/search/FieldComparator.java

Author: jpountz
Date: Wed Jul 23 17:29:43 2014
New Revision: 1612882

URL: http://svn.apache.org/r1612882
Log:
LUCENE-5835: Make TermValComparator extendable.


Modified:
    lucene/dev/branches/branch_4x/   (props changed)
    lucene/dev/branches/branch_4x/lucene/   (props changed)
    lucene/dev/branches/branch_4x/lucene/core/   (props changed)
    lucene/dev/branches/branch_4x/lucene/core/src/java/org/apache/lucene/search/FieldComparator.java

Modified: lucene/dev/branches/branch_4x/lucene/core/src/java/org/apache/lucene/search/FieldComparator.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/core/src/java/org/apache/lucene/search/FieldComparator.java?rev=1612882&r1=1612881&r2=1612882&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/lucene/core/src/java/org/apache/lucene/search/FieldComparator.java (original)
+++ lucene/dev/branches/branch_4x/lucene/core/src/java/org/apache/lucene/search/FieldComparator.java Wed Jul 23 17:29:43 2014
@@ -1154,7 +1154,7 @@ public abstract class FieldComparator<T>
    *  comparisons are done using BytesRef.compareTo, which is
    *  slow for medium to large result sets but possibly
    *  very fast for very small results sets. */
-  public static final class TermValComparator extends FieldComparator<BytesRef> {
+  public static class TermValComparator extends FieldComparator<BytesRef> {
     
     private final BytesRef[] values;
     private final BytesRef[] tempBRs;
@@ -1165,8 +1165,6 @@ public abstract class FieldComparator<T>
     private BytesRef topValue;
     private final int missingSortCmp;
 
-    // TODO: add missing first/last support here?
-
     /** Sole constructor. */
     public TermValComparator(int numHits, String field, boolean sortMissingLast) {
       values = new BytesRef[numHits];