[PR] sim: disable sim uart output processing [nuttx]

["Gary-Hobson (via GitHub)" <gi...@apache.org>]

Gary-Hobson opened a new pull request, #13966:
URL: https://github.com/apache/nuttx/pull/13966

   ## Summary
   Using the host serial port to send data in sim will convert \r to \r\n
   
   When using the host physical serial port in sim, the existing configuration will convert \r to \r\n when sending data.
   If the tty device used is not stdin/out, we need to set it to raw format
   
   ## Impact
   none
   
   ## Testing
   sim
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] sim: disable sim uart output processing [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #13966:
URL: https://github.com/apache/nuttx/pull/13966#issuecomment-2401471295

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **No, this PR does not meet the NuttX requirements.**
   
   **Missing Information:**
   
   * **Why is the change necessary?**  The summary states the "what" but not the "why". Is this a bug fix? A desired behavior change?  Clarity is needed.
   * **What functional part of the code is being changed?** Be specific. Which files/modules are affected?
   * **How does the change exactly work?** Provide a technical explanation of your solution. 
   * **Related Issues:** Are there any related issues in the NuttX or NuttX Apps repositories?
   * **Build Host(s):** Specify the OS, CPU architecture, and compiler used for testing.
   * **Target(s):** Which simulator and configuration were used?
   * **Testing logs:**  The provided logs are placeholders. Include actual logs showing the problem before and the solution after your change.
   
   **Recommendations:**
   
   1. **Expand the Summary:** Clearly articulate the problem, the reason for the change, and the specific area of the code being modified.
   2. **Explain the Solution:** Provide a technical description of how your code change addresses the issue.
   3. **Complete Testing Information:**  Provide detailed information about your testing environment and include actual logs demonstrating the problem and the successful outcome after applying your changes. 
   4. **Consider Impact:** Even if you believe the impact is minimal, explain your reasoning. For instance, if this change only affects simulated environments, state that explicitly.
   
   By providing the missing information, you will make your PR easier to review and increase the likelihood of it being accepted. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] sim: disable sim uart output processing [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #13966:
URL: https://github.com/apache/nuttx/pull/13966


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org