You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/01/16 00:31:59 UTC
[jira] Updated: (THRIFT-34) Java libraries should be namespaced
under org.apache.thrift, not com.facebook.thrift
[ https://issues.apache.org/jira/browse/THRIFT-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-34:
--------------------------------
Attachment: thrift-34-v2.patch
Ok, I updated the original patch with some changes to account for all the changes that have occurred since it was originally created. The changes it will make:
{code}
D lib/java/src/protocol
D lib/java/src/types
D lib/java/src/server
A lib/java/src/org
A + lib/java/src/org/apache
M + lib/java/src/org/apache/thrift/protocol/TList.java
M + lib/java/src/org/apache/thrift/protocol/TMap.java
M + lib/java/src/org/apache/thrift/protocol/TProtocolException.java
M + lib/java/src/org/apache/thrift/protocol/TType.java
M + lib/java/src/org/apache/thrift/protocol/TField.java
M + lib/java/src/org/apache/thrift/protocol/TMessage.java
M + lib/java/src/org/apache/thrift/protocol/TStruct.java
M + lib/java/src/org/apache/thrift/protocol/TMessageType.java
M + lib/java/src/org/apache/thrift/protocol/TProtocolFactory.java
M + lib/java/src/org/apache/thrift/protocol/TJSONProtocol.java
M + lib/java/src/org/apache/thrift/protocol/TSet.java
M + lib/java/src/org/apache/thrift/protocol/TProtocolUtil.java
M + lib/java/src/org/apache/thrift/protocol/TProtocol.java
M + lib/java/src/org/apache/thrift/protocol/TBase64Utils.java
M + lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java
M + lib/java/src/org/apache/thrift/protocol/TBinaryProtocol.java
M + lib/java/src/org/apache/thrift/TException.java
M + lib/java/src/org/apache/thrift/TByteArrayOutputStream.java
M + lib/java/src/org/apache/thrift/TProcessor.java
M + lib/java/src/org/apache/thrift/FieldMetaData.java
M + lib/java/src/org/apache/thrift/server/TSimpleServer.java
M + lib/java/src/org/apache/thrift/server/TServer.java
M + lib/java/src/org/apache/thrift/server/TThreadPoolServer.java
M + lib/java/src/org/apache/thrift/server/THsHaServer.java
M + lib/java/src/org/apache/thrift/server/TNonblockingServer.java
M + lib/java/src/org/apache/thrift/TApplicationException.java
M + lib/java/src/org/apache/thrift/TDeserializer.java
M + lib/java/src/org/apache/thrift/reflection/limited/Method.java
M + lib/java/src/org/apache/thrift/reflection/limited/Service.java
M + lib/java/src/org/apache/thrift/reflection/limited/TTypeTag.java
M + lib/java/src/org/apache/thrift/reflection/limited/Argument.java
M + lib/java/src/org/apache/thrift/reflection/limited/ThriftType.java
M + lib/java/src/org/apache/thrift/reflection/limited/ContainerType.java
M + lib/java/src/org/apache/thrift/reflection/limited/SimpleType.java
M + lib/java/src/org/apache/thrift/reflection/limited/Constants.java
M + lib/java/src/org/apache/thrift/TProcessorFactory.java
M + lib/java/src/org/apache/thrift/transport/TTransportException.java
M + lib/java/src/org/apache/thrift/transport/TFramedTransport.java
M + lib/java/src/org/apache/thrift/transport/TNonblockingSocket.java
M + lib/java/src/org/apache/thrift/transport/TTransport.java
M + lib/java/src/org/apache/thrift/transport/THttpClient.java
M + lib/java/src/org/apache/thrift/transport/TServerSocket.java
M + lib/java/src/org/apache/thrift/transport/TNonblockingTransport.java
M + lib/java/src/org/apache/thrift/transport/TIOStreamTransport.java
M + lib/java/src/org/apache/thrift/transport/TMemoryBuffer.java
M + lib/java/src/org/apache/thrift/transport/TServerTransport.java
M + lib/java/src/org/apache/thrift/transport/TNonblockingServerSocket.java
M + lib/java/src/org/apache/thrift/transport/TTransportFactory.java
M + lib/java/src/org/apache/thrift/transport/TNonblockingServerTransport.java
M + lib/java/src/org/apache/thrift/transport/TSocket.java
M + lib/java/src/org/apache/thrift/TSerializer.java
M + lib/java/src/org/apache/thrift/TBase.java
D lib/java/src/reflection
D lib/java/src/reflection/limited
D lib/java/src/transport
D lib/java/src/com
D lib/java/src/com/facebook
D lib/java/src/com/facebook/thrift
D lib/java/src/com/facebook/thrift/protocol
D lib/java/src/com/facebook/thrift/protocol/TList.java
D lib/java/src/com/facebook/thrift/protocol/TMap.java
D lib/java/src/com/facebook/thrift/protocol/TProtocolException.java
D lib/java/src/com/facebook/thrift/protocol/TType.java
D lib/java/src/com/facebook/thrift/protocol/TField.java
D lib/java/src/com/facebook/thrift/protocol/TMessage.java
D lib/java/src/com/facebook/thrift/protocol/TStruct.java
D lib/java/src/com/facebook/thrift/protocol/TMessageType.java
D lib/java/src/com/facebook/thrift/protocol/TProtocolFactory.java
D lib/java/src/com/facebook/thrift/protocol/TJSONProtocol.java
D lib/java/src/com/facebook/thrift/protocol/TSet.java
D lib/java/src/com/facebook/thrift/protocol/TProtocolUtil.java
D lib/java/src/com/facebook/thrift/protocol/TProtocol.java
D lib/java/src/com/facebook/thrift/protocol/TBase64Utils.java
D lib/java/src/com/facebook/thrift/protocol/TSimpleJSONProtocol.java
D lib/java/src/com/facebook/thrift/protocol/TBinaryProtocol.java
D lib/java/src/com/facebook/thrift/TException.java
D lib/java/src/com/facebook/thrift/TByteArrayOutputStream.java
D lib/java/src/com/facebook/thrift/TProcessor.java
D lib/java/src/com/facebook/thrift/FieldMetaData.java
D lib/java/src/com/facebook/thrift/server
D lib/java/src/com/facebook/thrift/server/TSimpleServer.java
D lib/java/src/com/facebook/thrift/server/TServer.java
D lib/java/src/com/facebook/thrift/server/TThreadPoolServer.java
D lib/java/src/com/facebook/thrift/server/THsHaServer.java
D lib/java/src/com/facebook/thrift/server/TNonblockingServer.java
D lib/java/src/com/facebook/thrift/TApplicationException.java
D lib/java/src/com/facebook/thrift/TDeserializer.java
D lib/java/src/com/facebook/thrift/reflection
D lib/java/src/com/facebook/thrift/reflection/limited
D lib/java/src/com/facebook/thrift/reflection/limited/Method.java
D lib/java/src/com/facebook/thrift/reflection/limited/Service.java
D lib/java/src/com/facebook/thrift/reflection/limited/TTypeTag.java
D lib/java/src/com/facebook/thrift/reflection/limited/Argument.java
D lib/java/src/com/facebook/thrift/reflection/limited/ThriftType.java
D lib/java/src/com/facebook/thrift/reflection/limited/ContainerType.java
D lib/java/src/com/facebook/thrift/reflection/limited/SimpleType.java
D lib/java/src/com/facebook/thrift/reflection/limited/Constants.java
D lib/java/src/com/facebook/thrift/TProcessorFactory.java
D lib/java/src/com/facebook/thrift/transport
D lib/java/src/com/facebook/thrift/transport/TTransportException.java
D lib/java/src/com/facebook/thrift/transport/TFramedTransport.java
D lib/java/src/com/facebook/thrift/transport/TNonblockingSocket.java
D lib/java/src/com/facebook/thrift/transport/TTransport.java
D lib/java/src/com/facebook/thrift/transport/THttpClient.java
D lib/java/src/com/facebook/thrift/transport/TServerSocket.java
D lib/java/src/com/facebook/thrift/transport/TNonblockingTransport.java
D lib/java/src/com/facebook/thrift/transport/TIOStreamTransport.java
D lib/java/src/com/facebook/thrift/transport/TMemoryBuffer.java
D lib/java/src/com/facebook/thrift/transport/TServerTransport.java
D lib/java/src/com/facebook/thrift/transport/TNonblockingServerSocket.java
D lib/java/src/com/facebook/thrift/transport/TTransportFactory.java
D lib/java/src/com/facebook/thrift/transport/TNonblockingServerTransport.java
D lib/java/src/com/facebook/thrift/transport/TSocket.java
D lib/java/src/com/facebook/thrift/TSerializer.java
D lib/java/src/com/facebook/thrift/TBase.java
M test/java/TestServer
M test/java/src/TestServer.java
M test/java/src/OverloadNonblockingServer.java
M test/java/src/DeepCopyTest.java
M test/java/src/IdentityTest.java
M test/java/src/ToStringTest.java
M test/java/src/TestNonblockingServer.java
M test/java/src/JavaBeansTest.java
M test/java/src/EqualityTest.java
M test/java/src/JSONProtoTest.java
M test/java/src/TestClient.java
M test/java/TestNonblockingServer
M test/java/TestClient
M test/java/build.xml
M compiler/cpp/src/generate/t_java_generator.cc
M contrib/fb303/java/FacebookBase.java
M contrib/fb303/java/FacebookService.java
M contrib/fb303/java/Constants.java
M tutorial/java/src/JavaClient.java
M tutorial/java/src/JavaServer.java
{code}
Everything still compiles and the tests pass.
I will commit this change if nobody objects.
> Java libraries should be namespaced under org.apache.thrift, not com.facebook.thrift
> ------------------------------------------------------------------------------------
>
> Key: THRIFT-34
> URL: https://issues.apache.org/jira/browse/THRIFT-34
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-34-v2.patch, THRIFT-34.patch, THRIFT-34.sh
>
>
> The Java libraries should be namespaced under org.apache.thrift. Currently they are under com.facebook.thrift.
> Also, at the same time, we should delete the protocol, reflection, server, transport, and types directories from lib/java/src. The usual java idiom would be src/org/apache/thrift/protocol (or what have you).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.