[GitHub] [hadoop] virajjasani commented on a diff in pull request #5330: HDFS-16898. Make write lock fine-grain in method processCommandFromActor

["virajjasani (via GitHub)" <gi...@apache.org>]

virajjasani commented on code in PR #5330:
URL: https://github.com/apache/hadoop/pull/5330#discussion_r1095229521


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java:
##########
@@ -679,16 +679,19 @@ boolean processCommandFromActor(DatanodeCommand cmd,
       actor.reRegister();
       return false;
     }
+    boolean isActiveActor;
     writeLock();
     try {
-      if (actor == bpServiceToActive) {
-        return processCommandFromActive(cmd, actor);
-      } else {
-        return processCommandFromStandby(cmd, actor);
-      }
+      isActiveActor = actor == bpServiceToActive;
     } finally {
       writeUnlock();
     }
+
+    if (actor == bpServiceToActive) {
+      return processCommandFromActive(cmd, actor);
+    } else {
+      return processCommandFromStandby(cmd, actor);
+    }

Review Comment:
   Even before HDFS-6788, this part was at least covered by synchronized lock on the actor thread



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org