You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/19 11:19:07 UTC

[GitHub] [spark] iRakson edited a comment on issue #27836: [SPARK-31009][SQL] Support json_object_keys function

iRakson edited a comment on issue #27836: [SPARK-31009][SQL] Support json_object_keys function
URL: https://github.com/apache/spark/pull/27836#issuecomment-601120259
 
 
   > > Do you know how much faster it is?
   > > > json_object_keys gives better performance than map_keys+from_json.
   > 
   > Has the @dongjoon-hyun comment above been already adderssed? If this func has performance benefits, I think its better to show the perf. numbers in the PR description.
   
   I have updated the time required for `map_keys+from_json` and `json_object_keys` in PR description. I will also try to add benchmark for all the new JSON functions.
   @maropu @HyukjinKwon 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org