You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2018/08/12 14:28:11 UTC
[GitHub] activemq-artemis pull request #2240: ARTEMIS-2025 Ensure correct calculation...
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2240
ARTEMIS-2025 Ensure correct calculation of message body size
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-2025
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2240
----
commit d9bc05d11265e7ea2e41212994b9955497a70a86
Author: Martyn Taylor <mt...@...>
Date: 2018-08-12T14:12:11Z
ARTEMIS-2025 Ensure correct calculation of message body size
----
---
[GitHub] activemq-artemis issue #2240: ARTEMIS-2025 Ensure correct calculation of mes...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2240
@mtaylor this test is failing after this:
org.apache.activemq.artemis.tests.integration.jms.jms2client.BodyTest.testBodyConversion
---
[GitHub] activemq-artemis issue #2240: ARTEMIS-2025 Ensure correct calculation of mes...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2240
@clebertsuconic @mtaylor seems also
MessageBodyTest.testBytesMessage is broker due to this change, and any PR build is failing now.
---
[GitHub] activemq-artemis issue #2240: ARTEMIS-2025 Ensure correct calculation of mes...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2240
@clebertsuconic It's called on receiveBody() so potentially once per message. I will look for an alternate approach.
---
[GitHub] activemq-artemis issue #2240: ARTEMIS-2025 Ensure correct calculation of mes...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2240
The Failure on your PR check is because you missed calling checkEncode(). It's currently private but we can open it to protected.
but don't worry.. I will amend the change as yours and merge it.
BTW: It's Sunday.. and we're working here :)
---
[GitHub] activemq-artemis issue #2240: ARTEMIS-2025 Ensure correct calculation of mes...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2240
@clebertsuconic done.
---
[GitHub] activemq-artemis pull request #2240: ARTEMIS-2025 Ensure correct calculation...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2240
---
[GitHub] activemq-artemis issue #2240: ARTEMIS-2025 Ensure correct calculation of mes...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2240
@clebertsuconic cheers
---