You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "juanthropic (via GitHub)" <gi...@apache.org> on 2026/10/06 21:56:14 UTC

[PR] libswoc: bound Vectray fixed span by element count [trafficserver]

juanthropic opened a new pull request, #13808:
URL: https://github.com/apache/trafficserver/pull/13808

   FixedStore::span() returned all N inline slots instead of the _count
   constructed ones. Every caller trusted it as the element range, so:
   
   - begin()/end() and range-for walked past the last element into
     uninitialized slots.
   - ~FixedStore() ran destructors on slots that were never constructed,
     which is undefined behavior for non-trivial T.
   
   The existing tests only used N=1 filled to capacity, where N equals
   _count, so the bug never showed. This adds two tests on a partially
   filled fixed store: one for iteration bounds, one for destructor
   count.
   
   Upstream libswoc has the same code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libswoc: bound Vectray fixed span by element count [trafficserver]

Posted by "juanthropic (via GitHub)" <gi...@apache.org>.
juanthropic commented on PR #13808:
URL: https://github.com/apache/trafficserver/pull/13808#issuecomment-6091174794

   [approve ci clang-analyzer]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libswoc: bound Vectray fixed span by element count [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #13808:
URL: https://github.com/apache/trafficserver/pull/13808


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libswoc: bound Vectray fixed span by element count [trafficserver]

Posted by "juanthropic (via GitHub)" <gi...@apache.org>.
juanthropic commented on PR #13808:
URL: https://github.com/apache/trafficserver/pull/13808#issuecomment-6150949168

   [approve ci osx]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] libswoc: bound Vectray fixed span by element count [trafficserver]

Posted by "juanthropic (via GitHub)" <gi...@apache.org>.
juanthropic commented on PR #13808:
URL: https://github.com/apache/trafficserver/pull/13808#issuecomment-6086639033

   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org